[LTP] [PATCH] tst_fill_fs: drop safe_macro from fill_flat_vec

Li Wang liwang@redhat.com
Wed Jun 21 03:32:09 CEST 2023


On Fri, Jun 16, 2023 at 8:30 PM Murphy Zhou <jencce.kernel@gmail.com> wrote:

> On Thu, Jun 15, 2023 at 3:53 PM Li Wang <liwang@redhat.com> wrote:
> >
> > LTP fs_fill is trying to spawn nCPUS thread to create corresponding
> > subdirectories and completely fill them. But in the invoke function
> > tst_fill_fs(, TST_FILL_BLOCKS) -> fill_flat_vec() which has SAFE_MACROs
> > to break the open behavior once fs is filled with ENOSPC return.
> >
> > The failure like there aren't enough free inodes in the filesystem for
> > the tst_fs_fill test program to create it's set of "AOF" data files.
> >
> >   4108  tst_test.c:1634: TINFO: === Testing on xfs ===
> >   4109  tst_test.c:1094: TINFO: Formatting /dev/loop0 with xfs opts=''
> extra opts=''
> >   4110  fs_fill.c:108: TINFO: Running 98 writer threads
> >   4111  tst_fill_fs.c:77: TBROK:
> openat(89</mnt/testarea/ltp-wGg0XNSHcr/LTP_fs_XLxrLh/mntpoint/thread84>,
> 'AOF', 101, 600): ENOSPC (28)
> >   4112  tst_fill_fs.c:77: TBROK:
> openat(87</mnt/testarea/ltp-wGg0XNSHcr/LTP_fs_XLxrLh/mntpoint/thread83>,
> 'AOF', 101, 600): ENOSPC (28)
> >   4113  tst_fill_fs.c:77: TWARN:
> openat(85</mnt/testarea/ltp-wGg0XNSHcr/LTP_fs_XLxrLh/mntpoint/thread82>,
> 'AOF', 101, 600): ENOSPC (28)
> >   4114  tst_fill_fs.c:77: TWARN:
> openat(3</mnt/testarea/ltp-wGg0XNSHcr/LTP_fs_XLxrLh/mntpoint/thread81>,
> 'AOF', 101, 600): ENOSPC (28)
> >
> > This patch is just to convert the fill_flat_vec() to ignore ENOSPC like
> > fill_randome() in opening subdirectories.
>
> Looks good to me. Thanks for fixing it!
>

Patch applied, thanks for your review.


-- 
Regards,
Li Wang


More information about the ltp mailing list