[LTP] [PATCH v3 1/2] rseq: Copy linux rseq test header files to ltp

Wei Gao wegao@suse.com
Tue Mar 14 14:49:48 CET 2023


On Mon, Mar 13, 2023 at 04:48:50PM +0100, Cyril Hrubis wrote:
> Hi!
> > Signed-off-by: Wei Gao <wegao@suse.com>
> > ---
> >  include/lapi/compiler.h                    |   30 +
> >  include/lapi/rseq-abi.h                    |  151 +++
> >  include/lapi/rseq-arm.h                    |  827 ++++++++++++
> >  include/lapi/rseq-arm64.h                  |  695 ++++++++++
> >  include/lapi/rseq-generic-thread-pointer.h |   25 +
> >  include/lapi/rseq-mips.h                   |  777 +++++++++++
> >  include/lapi/rseq-ppc-thread-pointer.h     |   30 +
> >  include/lapi/rseq-ppc.h                    |  791 ++++++++++++
> >  include/lapi/rseq-riscv.h                  |  677 ++++++++++
> >  include/lapi/rseq-s390.h                   |  610 +++++++++
> >  include/lapi/rseq-skip.h                   |   65 +
> >  include/lapi/rseq-thread-pointer.h         |   19 +
> >  include/lapi/rseq-x86-thread-pointer.h     |   40 +
> >  include/lapi/rseq-x86.h                    | 1365 ++++++++++++++++++++
> 
> We actually does not need most of the code. The only thing that we use
> from the architecture specific headers is the RSEQ_SIG constant. So
> unless you actually plan to write tests that use the assembly code in
> these headers I would put just the RSEQ_SIG into the lapi/rseq.h instead.
> 
> There is no point in adding complex code that is not going to the be
> used.
> 
Yes, indeed, that's why i have made a patch v5 to ONLY work on x86_64 together with only function/macro to be 
used. Try to make test case small but the size is still big. This system call has no easy/friendly end user inteface
.

> -- 
> Cyril Hrubis
> chrubis@suse.cz


More information about the ltp mailing list