[LTP] [PATCH v2 1/2] Rewrite fsx-linux test

[Andrea Cervesato]

Hi Petr,

> On 20 Nov 2023, at 17:50, Petr Vorel <pvorel@suse.cz> wrote:
> 
> Hi Andrea,
> 
>> Hi!
> 
>>> On 11/1/23 11:53, Cyril Hrubis wrote:
>>> Hi!
>>>>> +++ b/testcases/kernel/fs/fsx-linux/fsx-linux.c
>>>>> @@ -1,1353 +1,392 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>>>>  /*
>>>>>   * Copyright (C) 1991, NeXT Computer, Inc.  All Rights Reserverd.
>>>>> - * Copyright (c) 1998-2001 Apple Computer, Inc. All rights reserved.
>>>>> - *
>>>>> - * @APPLE_LICENSE_HEADER_START@
>>>>> - *
>>>>> - * The contents of this file constitute Original Code as defined in and
>>>>> - * are subject to the Apple Public Source License Version 1.1 (the
>>>>> - * "License").  You may not use this file except in compliance with the
>>>>> - * License.  Please obtain a copy of the License at
>>>>> - * http://www.apple.com/publicsource and read it before using this file.
>>>> I wonder if we can switch from APSL-1.1 to GPL-2.0-or-later
>>>> https://spdx.org/licenses/APSL-1.1.html
> 
>>>> "This is a complete rewrite of the old test." may justify that.
>>> The test was written from scratch based loosely on what the original
>>> stress test did, so I would say that the new license is okay.
> 
>>> But I suggested adding "Based on fxs.c test by Next Computer, Inc."
>>> instead of the copyright lines, since I suppose that once we add these
>>> copyrights we have to keep the original license.
>> This is explained in the description.
> 
> If you mean the commit message description, that's IMHO not enough.
> Statements like this are added into the source code header so that people who
> download tarballs see it as well.
> 

I meant the test Description section.

> Kind regards,
> Petr