[LTP] [PATCH 1/1] diotest4: Skip test 3 and 14 for tmpfs

Jan Kara jack@suse.cz
Thu Nov 23 09:51:29 CET 2023


On Wed 22-11-23 22:13:18, Petr Vorel wrote:
> tmpfs in kernel v6.6 got support for O_DIRECT in e88e0d366f9c ("tmpfs:
> trivial support for direct IO"). There is no reason for tmpfs to reject
> direct IO of any size therefore follow the approach already used for
> Btrfs, NFS and FUSE: skipping test 3 (odd count of read and write)
> and 14 (read, write with non-aligned buffer).
> 
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Looks good, thanks for writing this! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  testcases/kernel/io/direct_io/diotest4.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/testcases/kernel/io/direct_io/diotest4.c b/testcases/kernel/io/direct_io/diotest4.c
> index 45c677b5b..ad00fa3e0 100644
> --- a/testcases/kernel/io/direct_io/diotest4.c
> +++ b/testcases/kernel/io/direct_io/diotest4.c
> @@ -270,6 +270,7 @@ int main(int argc, char *argv[])
>  	case TST_NFS_MAGIC:
>  	case TST_BTRFS_MAGIC:
>  	case TST_FUSE_MAGIC:
> +	case TST_TMPFS_MAGIC:
>  		tst_resm(TCONF, "%s supports odd count IO",
>  			 tst_fs_type_name(fs_type));
>  	break;
> @@ -443,6 +444,7 @@ int main(int argc, char *argv[])
>  	case TST_NFS_MAGIC:
>  	case TST_BTRFS_MAGIC:
>  	case TST_FUSE_MAGIC:
> +	case TST_TMPFS_MAGIC:
>  		tst_resm(TCONF, "%s supports non-aligned buffer",
>  			 tst_fs_type_name(fs_type));
>  	break;
> -- 
> 2.42.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR


More information about the ltp mailing list