[LTP] [PATCH v2 2/2] ci: Check for undefined variables in all scripts

Richard Palethorpe rpalethorpe@suse.com
Mon Oct 9 12:24:05 CEST 2023


Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Suggested-by: Petr Vorel <pvorel@suse.cz>
---
 ci/alpine.sh               | 3 +--
 ci/debian.cross-compile.sh | 3 +--
 ci/debian.i386.sh          | 3 +--
 ci/debian.minimal.sh       | 3 +--
 ci/debian.sh               | 3 +--
 ci/fedora.sh               | 3 +--
 ci/tumbleweed.sh           | 3 +--
 7 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/ci/alpine.sh b/ci/alpine.sh
index 9ae5a8d07..efd1f6de4 100755
--- a/ci/alpine.sh
+++ b/ci/alpine.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2019-2022 Petr Vorel <petr.vorel@gmail.com>
-set -ex
 
 apk update
 
diff --git a/ci/debian.cross-compile.sh b/ci/debian.cross-compile.sh
index 0a7ef7710..e2dea2ee0 100755
--- a/ci/debian.cross-compile.sh
+++ b/ci/debian.cross-compile.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2020 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 if [ -z "$ARCH" ]; then
 	echo "missing \$ARCH!" >&2
diff --git a/ci/debian.i386.sh b/ci/debian.i386.sh
index 707a23ca6..e6017de65 100755
--- a/ci/debian.i386.sh
+++ b/ci/debian.i386.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2020 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 dpkg --add-architecture i386
 apt update
diff --git a/ci/debian.minimal.sh b/ci/debian.minimal.sh
index b51154b05..780258676 100755
--- a/ci/debian.minimal.sh
+++ b/ci/debian.minimal.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2023 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 apt="apt remove -y"
 
diff --git a/ci/debian.sh b/ci/debian.sh
index da92337fb..6d0c9eb13 100755
--- a/ci/debian.sh
+++ b/ci/debian.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2021 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 # workaround for missing oldstable-updates repository
 # W: Failed to fetch http://deb.debian.org/debian/dists/oldstable-updates/main/binary-amd64/Packages
diff --git a/ci/fedora.sh b/ci/fedora.sh
index a603bcbe3..2e4e87bca 100755
--- a/ci/fedora.sh
+++ b/ci/fedora.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2021 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 yum="yum -y install --skip-broken"
 
diff --git a/ci/tumbleweed.sh b/ci/tumbleweed.sh
index f1e7252f2..2e2b05aa5 100755
--- a/ci/tumbleweed.sh
+++ b/ci/tumbleweed.sh
@@ -1,6 +1,5 @@
-#!/bin/sh
+#!/bin/sh -eux
 # Copyright (c) 2018-2021 Petr Vorel <pvorel@suse.cz>
-set -ex
 
 zyp="zypper --non-interactive install --force-resolution --no-recommends"
 
-- 
2.40.1



More information about the ltp mailing list