[LTP] [PATCH 1/3] link03: Convert docs to docparse

Yang Xu (Fujitsu) xuyang2018.jy@fujitsu.com
Fri Oct 13 07:43:43 CEST 2023


Hi Petr,
> Hi Xu,
>
> first, so far we did these changes during rewrite to the new C API.
> Do we really put docparse on these old tests? I would postpone it.

I agree with you, I overlooked that this is an old test.

You can postpone it, maybe in the future I will rewrite to the new C API.

>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>>   testcases/kernel/syscalls/link/link03.c | 41 +++++--------------------
>>   1 file changed, 7 insertions(+), 34 deletions(-)
>> diff --git a/testcases/kernel/syscalls/link/link03.c b/testcases/kernel/syscalls/link/link03.c
>> index 1f45240ae..27f8a4efe 100644
>> --- a/testcases/kernel/syscalls/link/link03.c
>> +++ b/testcases/kernel/syscalls/link/link03.c
>> @@ -1,42 +1,15 @@
>>   /*
>>    * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
>> - *  AUTHOR		: Richard Logan
>> - *  CO-PILOT		: William Roske
>> + * AUTHOR		: Richard Logan
>> + * CO-PILOT		: William Roske
> Although we probably should keep these names, we're not forced to have it in
> original ugly form. How about put it as:
> * Authors: Richard Logan, William Roske
>
ok.
>>    * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>
> I would also put here:
> * Copyright (c) Linux Test Project, 2001-2023
ok.
>> - *
>> - * This program is free software; you can redistribute it and/or modify it
>> - * under the terms of version 2 of the GNU General Public License as
>> - * published by the Free Software Foundation.
>> - *
>> - * This program is distributed in the hope that it would be useful, but
>> - * WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>> - *
>> - * Further, this software is distributed without any warranty that it is
>> - * free of the rightful claim of any third person regarding infringement
>> - * or the like.  Any license provided herein, whether implied or
>> - * otherwise, applies only to this software file.  Patent licenses, if
>> - * any, provided herein do not apply to combinations of this program with
>> - * other software, or any other product whatsoever.
>> - *
>> - * You should have received a copy of the GNU General Public License along
>> - * with this program; if not, write the Free Software Foundation, Inc.,
>> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>> - *
>> - * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy,
>> - * Mountain View, CA  94043, or:
>> - *
>> - * http://www.sgi.com
>> - *
>> - * For further information regarding this notice, see:
>> - *
>> - * http://oss.sgi.com/projects/GenInfo/NoticeExplan/
>> - *
>>    */
> You removed GPL, but haven't added SPDX on a first line:
> // SPDX-License-Identifier: GPL-2.0-only
Sorry for ignoring this.
>> - /*
>> -  * Tests that link(2) succeds with creating n links.
>> -  */
>> +/*\
>> + * [Description]
>> + *
>> + * Tests that link(2) succeds with creating n links.
> s/succeds/succeeds/g
>> + */
> Kind regards,
> Petr
>
>>   #include <sys/types.h>
>>   #include <fcntl.h>


More information about the ltp mailing list