[LTP] [PATCH v7 3/5] Remove disabled code in ioctl02.c

Martin Doucha mdoucha@suse.cz
Tue Oct 24 17:02:57 CEST 2023


Hi,
the first 3 patches can be merged as is. For all patches up to here:

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 23. 10. 23 18:02, Marius Kittler wrote:
> Signed-off-by: Marius Kittler <mkittler@suse.de>
> ---
>   testcases/kernel/syscalls/ioctl/ioctl02.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl02.c b/testcases/kernel/syscalls/ioctl/ioctl02.c
> index 25b83d358..c66473a8d 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl02.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl02.c
> @@ -134,20 +134,6 @@ static void chk_tty_parms(void)
>   			 termio.c_line);
>   		flag++;
>   	}
> -	/*
> -	 * The following Code Sniffet is disabled to check the value of c_cflag
> -	 * as it seems that due to some changes from 2.6.24 onwards, this
> -	 * setting is not done properly for either of (B50|CS7|CREAD|PARENB|
> -	 * PARODD|CLOCAL|(CREAD|HUPCL|CLOCAL).
> -	 * However, it has been observed that other flags are properly set.
> -	 */
> -#if 0
> -	if (termio.c_cflag != (B50 | CS7 | CREAD | PARENB | PARODD | CLOCAL)) {
> -		tst_res(TINFO, "cflag has incorrect value. %o",
> -			 termio.c_cflag);
> -		flag++;
> -	}
> -#endif
>   
>   	for (i = 0; i < NCC; i++) {
>   		if (i == VEOL2) {

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list