[LTP] [PATCH] Use correct ioctl request for termios

Cyril Hrubis chrubis@suse.cz
Mon Sep 4 18:11:02 CEST 2023


Hi!
> But we have currently 4 tests that are all executed via both termio and 
> termios. To keep this kind of coverage we would need to duplicate all of those 
> lines. That would be 4 new test lines in total. Is that what you're 
> suggesting? I'm just asking twice because I'm not sure whether it is better 
> (but don't have a strong opinion).

Yes, as far as I can tell one test per entry is much cleaner and easier
to read.

> By the way, how would I submit an amendment here? Just submit the amended 
> commit again in the same way (I used `git send-email --
> to=ltp@lists.linux.it`)?

Yes, and you are supposed to version the commits, so add to format-patch
-v2 for second version, etc.

> And how is this merged? I saw that in another case patchwork was used? How 
> does that come into play?

Things get merged by maintainers who apply the patch to their local git
tree and then push to github. Patchwork is just a tool that monitors the
mailing list and saves a list of patches that needs review, which makes
things easier for developers as it's easy for patches to get burried in
their mailboxes.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list