[LTP] [PATCH v2] kernel/device-drivers/zram/zram01.sh : don't fill from /dev/zero

Martin Doucha mdoucha@suse.cz
Thu Sep 7 12:18:38 CEST 2023


On 07. 09. 23 8:46, Ian Wienand wrote:
> I don't think adding another test really helps.
> 
> I think the best course here is to fix zram01.sh to write enough
> random data to stress the compression paths and further sync to make
> it reliable.  This is what the patch proposes.
> 
> If there's some agreement that the investigation above is valid, we
> could probably remove zram03.c.  It's not really doing anything
> zram01.sh doesn't do and it is not really stressing anything either.

Please do not completely rewrite test scenarios to hide one failure due 
to filesystem specifics. If this is not a kernel bug, the correct way to 
deal with this is to disable testing on vfat in initialize_vars():

for fs in $(tst_supported_fs -s tmpfs,vfat); do
...

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list