[LTP] [PATCH 3/3] nfs_lib.sh: Fail the test if NFS unmount fails

Petr Vorel pvorel@suse.cz
Mon Sep 25 19:40:57 CEST 2023


Hi,

...
> > > > -			umount $local_dir
> > > > +			umount $local_dir || tst_res TFAIL "Unmount failed"

> > > I suppose that this should be TBROK instead. And that this, apart from

> > Right, TBROK looks to be the best.
> > Martin, if you're ok with the change, I'll update it before merge (after the
> > release).
> I don't see the point. This is a cleanup function. The TBROK will be changed
> to TWARN and the test will continue anyway.

But TFAIL in cleanup function looks to me strange as well. Should we endup with
TWARN then?

Kind regards,
Petr


More information about the ltp mailing list