[LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO

Petr Vorel pvorel@suse.cz
Wed Apr 17 20:38:32 CEST 2024


> Hi!
> > Changing it to {SAFE_,}MAKE_SWAPFILE_SIZE() on all places would mean we don't need
> > {SAFE_,}MAKE_SWAPFILE_BLKS() at all. Therefore I think this check should be
> > suppressed to TINFO. Other option is to use high enough value (more blocks)
> > (not sure if using really small swap file makes sense anyway).

> I do not think that we should use too small swap file even for the case
> where we try to detect if swapfiles are supported. Currently it seems
> that kernel accepts swapfiles smaller than page size, but it may also
> start rejecting them with EINVAL in the future.

> So I would keep the warning and rather tried to fix all the parts where
> we attempt to create a swapfile smaller than page size.

+1, setting "changes requested", I'll send v2 with higher number of blocks to
fix this.

Kind regards,
Petr


More information about the ltp mailing list