[LTP] [PATCH 1/1] libs: Remove 'libltp' prefix from libs source directories

Petr Vorel pvorel@suse.cz
Sat Apr 20 10:54:37 CEST 2024


Hi Li, Cyril,

> Hi Petr, Cyril,

> On Fri, Apr 19, 2024 at 7:02 PM Petr Vorel <pvorel@suse.cz> wrote:

> > LTP internal libraries are located in libs/ directory. There is no need
> > to keep 'libltp' prefix in their own directories. NOTE: resulted
> > libraries (*.a) keep expected 'libltp' prefix.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Hi Li, Cyril,

> > I know renaming files is not optimal. But history will be kept, when
> > browsing with gitk or git gui.

> > Improvement: less typing when cd to the directory.


> +1 I agree with this, and I always have a question, why
> we have additional libs/ parallel with lib/, is there any root

lib/ sources results in libltp.a, the others results in their own libs.

Although lib/ vs libs/ is a bit strange, kept these libraries separate
(i.e. no move libs/*/ into lib/), because these libraries are built only when
they are needed. I.e. for testing random test one does not need to wait for
building these additional libraries (although building them does not take long,
building LTP main library and tests takes much longer). But if we want, we can
move them to lib/ (as a separate effort, even this might make some patches in
ML unapplicable without patch modification).

> difference between them? or just a historical issue?

> Anyway, this patch looks good to me.

Thanks!

Kind regards,
Petr

> > Tested:
> > https://github.com/pevik/ltp/actions/runs/8752048451

> > Kind regards,
> > Petr


More information about the ltp mailing list