[LTP] [PATCH v5 6/7] syscalls/swapon03: Simply this case

Yang Xu (Fujitsu) xuyang2018.jy@fujitsu.com
Wed Feb 28 09:15:05 CET 2024


Hi Petr

> Hi Yang Xu,
> 
>> By moving swapfile create stage from verify_swaopon and
>> test EPERM error more accurate. Also use glibc wrapper by
>> using swapon/swapoff instead of call syscall number directly
>> because glibc/musl/binoic also support them since long time ago.
> s/binoic/bionic/
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks for your nice review. Sorry, when your review v4 patch, I don't 
solve all comment in v5. So I did it in my own ltp fork branch named as 
v5_max_swapfiles[1](such as swapfiles => swap file, snprint return 
value, else branch....).

ps: Only the 6th patch was modified, other patches aren't modified. If 
you see no problem, I plan to merge this patchset today.

[1]https://github.com/xuyang0410/ltp/commits/v5_max_swapfiles/

Best Regards
Yang Xu
> 
> Kind regards,
> Petr


More information about the ltp mailing list