[LTP] [PATCH v4 09/10] lib: Add support for TDEBUG tst_res() flag

[Li Wang]

On Thu, Jan 4, 2024 at 7:37 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi all,
>
> > To print more verbose info. By default it's off, printing enabled with
> > -D option or TST_ENABLE_DEBUG=1.
>
> ...
> > diff --git a/doc/C-Test-API.asciidoc b/doc/C-Test-API.asciidoc
> ...
> > +| 'TINFO'  | General message.
> > +| 'TDEBUG' | Debug message (new C API only, printed with '-D' or via
> 'TST_ENABLE_DEBUG=1' or 'y'
> > +             environment variable), only for messages which would be
> too verbose for normal run.
> ...
> > +++ b/doc/User-Guidelines.asciidoc
> > @@ -41,6 +41,7 @@ For running LTP network tests see
> `testcases/network/README.md`.
> >                            and others, which imply it, shell:
> 'TST_NEEDS_TMPDIR=1').
> >                            Must be an absolute path (default: '/tmp').
> >  | 'TST_NO_CLEANUP'      | Disable running test cleanup (defined in
> 'TST_CLEANUP').
> > +| 'TST_ENABLE_DEBUG'    | Enable debug info (value 'y' or '1').
>
> This has been merged. But I now wonder, if this would be better with LTP_
> prefix, e.g. LTP_ENABLE_DEBUG, because it's a variable which is defined by
> LTP
> user. WDYT?
>

+1 for LTP_ENABLE_DEBUG

Good point, as it is designed for the whole LTP test, so the first
level should be more proper. Similary with LTP_RUNTIME_MUL.


> This might be also case for TST_NO_CLEANUP, but it's rarely used, thus my
> concern is more about LTP_ENABLE_DEBUG.
>
> Kind regards,
> Petr
>
>

-- 
Regards,
Li Wang