[LTP] [PATCH 2/2] runtest/net.nfs: Rename test names

Petr Vorel pvorel@suse.cz
Sun Jan 21 20:37:56 CET 2024


> Hi!
> > -nfs01_06  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> > -nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > -nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_v3_v4_ipv4_tcp_udp  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_vall_ipv4tcp nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> > +nfs06.sh_v4*_ipv6_tcp nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"

> Putting * into a test name is asking for a trouble, who knows where it
> may expand...

Hi Cyril,

would be nfs06.sh_v4+_ipv6_tcp better? or nfs06.sh_v4plus_ipv6_tcp
Or should I merge as nfs06.sh_v4_ipv6_tcp

Thanks a lot for having a look!

Kind regards,
Petr

> Otherwise I'm all for having more descriptive names:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


More information about the ltp mailing list