[LTP] [PATCH v1] Delete fork09 test

Andrea Cervesato andrea.cervesato@suse.com
Tue Mar 12 16:19:22 CET 2024


Hi!

On 12/20/23 13:29, Petr Vorel wrote:
>> On Tue, Dec 19, 2023 at 10:55 PM pvorel <pvorel@suse.de> wrote:
>>> Hi all,
>>> On 2023-11-28 13:56, Petr Vorel wrote:
>>>> Hi Andrea,
>>>>> From: Andrea Cervesato <andrea.cervesato@suse.com>
>>>>> The fork09 test is actually testing what fork10 is already testing:
>>>>> accessing an open child's file from parent. For this reason, we delete
>>>>> it and let fork10 doing its job.
>>>> in fork09 parent opens maximum number of files, child closes one and
>>>> attempts to
>>>> open another. That is not exactly the same, but it's very similar.
>>>> I'm not sure if the scenario would really tests different code path in
>>>> kernel/libc or not and we can happily delete it.
>>>> Cyril, WDYT?
>>> @Li, WDYT?
>
>> Petr, I think you're right, they're not the same test.
>> In fork10 parent tries to verify the contents of the file that reset the
>> file offset pointer by child.
>> But for09 is a bounder test to verify if the child can open one more file
>> when 'fd' number approaches (OpenMax-1).
> Thank you! Closing this as rejected, Andrea feel free to rewrite the test as
> well.

The reason why this test should be deleted is contained in the following 
discussion, but I can rewrite it if it's strictly necessary.

https://patchwork.ozlabs.org/project/ltp/patch/20230907150538.16772-1-andrea.cervesato@suse.de/
> Kind regards,
> Petr

Andrea



More information about the ltp mailing list