[LTP] [PATCH v4] Refactor fork14 using new LTP API

Petr Vorel pvorel@suse.cz
Fri Mar 22 10:36:55 CET 2024


Hi Andrea,

> > generally LGTM.
> > With using .skip_in_compat and SPDX GPL-2.0-only:
> Totally forgot the license..

Thanks for sending v5.

...
> > > -		default:
> > > -			SAFE_WAITPID(cleanup, -1, NULL, 0);
> > > -			if (prev_failed > 0 && i >= LARGE) {
> > > -				tst_resm(TFAIL, "Fork succeeds incorrectly");
> > > -				reproduced = 1;
> > > -				goto clear_memory_map;
> > > -			}
> > > +		ret = waitpid(pid, NULL, 0);
> > Why not SAFE_WAITPID() as it was originally?
> Was discussed with Cyril in the previous review. It's because we don't want
> it to fail only once.

Ah, I'm sorry, I overlooked it.

Kind regards,
Petr


More information about the ltp mailing list