<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 26, 2015 at 9:49 PM, Cyril Hrubis <span dir="ltr"><<a href="mailto:chrubis@suse.cz" target="_blank">chrubis@suse.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi!<br>
<span class="">> > forgot "static"?<br>
> ><br>
><br>
> no, it will be conflict with the prototype in mem.h and get compiler error<br>
> like:<br>
> -------<br>
</span>> hugemmap05.c:253: error: static declaration of ???cleanup??? follows non-static<br>
> declaration<br>
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:100:<br>
> note: previous declaration of ???cleanup??? was here<br>
> hugemmap05.c:295: error: static declaration of ???setup??? follows non-static<br>
> declaration<br>
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:101:<br>
> note: previous declaration of ???setup??? was here<br>
<span class="">> make: *** [hugemmap05] Error 1<br>
<br>
</span>Why have you added the function into the mem/include/mem.h in the first<br>
place? There is kernel/mem/hugetlb/lib/ directory allready, just make<br>
use of it.<br></blockquote><div><br></div><div>sounds good. how about moving the current hugetlb/lib/* two file:<br><br>ipcshm.h ---> hugetlb.h <br>libipc.c    ----> hugetlb.c<br></div><div> </div></div>and re-write some functions in it? <br>then we can take a good use of it to build a lib_hugetlb.a.<br><br></div><div class="gmail_extra">if all of you have no objection, I can do that.<br></div><div class="gmail_extra"><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Regards,<br></div>Li Wang<br></div><div>Email: <a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a><br></div></div></div></div></div></div>
</div></div>