<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 17, 2015 at 3:27 PM, Li Wang <span dir="ltr"><<a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
diff -uprN a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c<br>
--- a/testcases/kernel/syscalls/creat/creat09.c 2015-12-03 05:53:41.000000000 +0900<br>
+++ b/testcases/kernel/syscalls/creat/creat09.c 2015-12-06 01:48:34.757125367 +0900<br>
@@ -139,9 +139,13 @@ int main(int ac, char **av)<br>
<br>
                TEST(creat(fname, 0700));<br>
<br>
-               if (TEST_RETURN == -1) {<br>
+               if (TEST_RETURN != -1) {<br>
                        tst_resm(TPASS, "creat(%s, 0700) returned %ld",<br>
                                 fname, TEST_RETURN);<br>
+               } else {<br>
+                       tst_resm(TFAIL | TTERRNO, "creat(%s, 0700) FAILED",<br>
+                                fname);<br>
+                       continue;   </blockquote></span><div> <br>why using continue here?   it will skip some cleanup codes in the following.<br><br></div></div></div></blockquote><div><br>oops!! if no "continue" here,  the process will going to handle wrong file descriptor.<br><br>you are right, sorry for make noise here, pls ignore my comments.<br></div></div><br>---<br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Li Wang<br></div></div></div></div></div></div>
</div></div>