<div dir="ltr"><div>Hi,<br><br></div>Thanks for reviewing. Comments in follows: <br><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 18, 2016 at 12:50 AM, Cyril Hrubis <span dir="ltr"><<a href="mailto:chrubis@suse.cz" target="_blank">chrubis@suse.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi!<br>
<div><div>> +###############################################################################<br>
> +#                                                                             #<br>
> +# Copyright (c) 2015, Red Hat Inc.                                            #<br>
> +#                                                                             #<br>
> +# This program is free software; you can redistribute it and/or modify it     #<br>
> +# under the terms of the GNU General Public License as published by the Free  #<br>
> +# Software Foundation; either version 2 of the License, or (at your option)   #<br>
> +# any later version.                                                          #<br>
> +#                                                                             #<br>
> +# PURPOSE: check signal:signal_generate gives 2 more fields: grp res          #<br>
> +#                                                                             #<br>
> +# This testcase is verifing signal events change:                             #<br>
> +#        6c303d3 tracing: let trace_signal_generate() report more info...     #<br>
> +#        163566f tracing: send_sigqueue() needs trace_signal_generate() too   #<br>
> +#                                                                             #<br>
> +###############################################################################<br>
> +<br>
> +<br>
> +# Set envent<br>
> +echo 'signal:signal_generate' > $TRACING_PATH/set_event<br>
> +<br>
> +echo 1 > $TRACING_PATH/tracing_on<br>
> +<br>
> +echo > $TRACING_PATH/trace<br>
> +<br>
> +sleep 10<br>
<br>
</div></div>Why sleep 10 here?<br></blockquote><div><br></div><div>It's waiting for ftrace capture the system trace. There probably no any trace be recorded if we check it at once.<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
> +grep -q 'grp=[0-9] res=[0-9]' $TRACING_PATH/trace<br>
> +if [ $? -eq 0 ]; then<br>
> +     exit 0<br>
> +else<br>
> +     exit 1<br>
> +fi<br>
<br>
</span>Use test.sh and tst_resm instead.<br></blockquote><div><br></div><div>Sure, I'd like to make change of the patches(2/9  -- 5/9) as your suggested.<br><br>CC' chuhu@ here. Since the patches(6/9  -- 9/9) were signed off by him.<br></div><div> </div></div><br clear="all"><br>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Regards,<br></div>Li Wang<br></div><div>Email: <a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a><br></div></div></div></div></div></div>
</div></div></div>