<html><head></head><body><div style="color:#000; background-color:#fff; font-family:Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div><span>Hi Cyril,</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7456"><span><br></span></div><div id="yui_3_16_0_ym19_1_1488502447053_7452"><span id="yui_3_16_0_ym19_1_1488502447053_7453">Thanks. I was thought it's one line (same as some other lines in this file eg. 109), so I tried to put them similiar</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span>But agreed, I also prefer curly braces when coding :D</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span><br></span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span id="yui_3_16_0_ym19_1_1488502447053_7430">I will send new patch, with moving it to setup() also.</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span><br></span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span>Thanks for your review</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span><br></span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span>Best regards,</span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span><br></span></div><div id="yui_3_16_0_ym19_1_1488502447053_7394"><span>Hoang</span></div><div class="qtdSeparateBR" id="yui_3_16_0_ym19_1_1488502447053_7393"><br><br></div><div class="yahoo_quoted" id="yui_3_16_0_ym19_1_1488502447053_7247" style="display: block;"> <div style="font-family: Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;" id="yui_3_16_0_ym19_1_1488502447053_7246"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, Sans-Serif; font-size: 16px;" id="yui_3_16_0_ym19_1_1488502447053_7245"> <div dir="ltr" id="yui_3_16_0_ym19_1_1488502447053_7244"> <font size="2" face="Arial" id="yui_3_16_0_ym19_1_1488502447053_7385"> <hr size="1" id="yui_3_16_0_ym19_1_1488502447053_7384"> <b><span style="font-weight:bold;">From:</span></b> Cyril Hrubis <chrubis@suse.cz><br> <b><span style="font-weight: bold;">To:</span></b> the_hoang0709@yahoo.com <br><b><span style="font-weight: bold;">Cc:</span></b> ltp@lists.linux.it<br> <b><span style="font-weight: bold;">Sent:</span></b> Thursday, 2 March 2017, 23:10<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [LTP] [PATCH] min_free_kbytes : Check panic_on_oom before running<br> </font> </div> <div class="y_msg_container" id="yui_3_16_0_ym19_1_1488502447053_7391"><br>Hi!<div class="yqt8195792776" id="yqtfd03483"><br clear="none">> diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c<br clear="none">> index cb00f40..8b6dc1c 100644<br clear="none">> --- a/testcases/kernel/mem/tunable/min_free_kbytes.c<br clear="none">> +++ b/testcases/kernel/mem/tunable/min_free_kbytes.c<br clear="none">> @@ -71,6 +71,9 @@ int main(int argc, char *argv[])<br clear="none">> <br clear="none">> tst_parse_opts(argc, argv, NULL, NULL);<br clear="none">> <br clear="none">> + if (get_sys_tune("panic_on_oom"))<br clear="none">> + tst_brkm(TCONF, NULL,<br clear="none">> + "panic_on_oom is set, disable it to run these testcases");</div><br clear="none"><br clear="none">This check should be put into the test setup() and LKML coding style<br clear="none">prefers curly braces around multiline statemets like this.<br clear="none"><br clear="none">Otherwise it looks fine.<br clear="none"><br clear="none">-- <br clear="none">Cyril Hrubis<br clear="none"><a shape="rect" ymailto="mailto:chrubis@suse.cz" href="mailto:chrubis@suse.cz">chrubis@suse.cz</a><div class="yqt8195792776" id="yqtfd45338"><br clear="none"></div><br><br></div> </div> </div> </div></div></body></html>