<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><font size="-1">Hi Alexey <br>
</font></p>
<p><font size="-1">This is my first attempt to contribute to LTP
project. Disadvantage of this is the fact that I can ask some
obvious for you question ( hope you will forgive me that) , but
advantage that I have a fresh look so I can point out to something
that is wrong but you just get used too. <br>
</font></p>
<p><font size="-1">First of all let's clarify something not related
to this PR directly :</font><br>
</p>
<br>
<blockquote type="cite"
cite="mid:20180504144103.mglidc376gvtb25z@dell5510">
<blockquote type="cite">
<pre wrap="">And why it is more appropriate? TCONF is not an error message.
</pre>
</blockquote>
</blockquote>
In LTP documentation TCONF defined as - "The test case was not
appropriate for the current hardware or software configuration". So
I would not call it error too but I would say that it is some flavor
of "SKIPPED" state. <br>
Where you want to say "this test case can't run currently so I can't
say if it is passed or failed" <br>
<br>
Second thing which needs to be taken in consideration I clarified
with Petr Vorel in conversation outside this ML - test counter
changed only on TPASS or TFAIL. This lead us to really confusing log
output :<br>
<br>
<ol style="margin: 1em 15px; padding: 0px 1em 0px 50px; border: 0px;
outline: 0px; font-size: 13.6px; background: rgb(246, 246, 246);
list-style: decimal inside; color: rgb(68, 68, 68); font-family:
monospace; font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration-style: initial; text-decoration-color: initial;">
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: initialize 'lhost'
'ltp_ns_veth2' interface</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: set local addr
10.0.0.2/24</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: set local addr
fd00:1:1:1::2/64</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: initialize 'rhost'
'ltp_ns_veth1' interface</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: set remote addr
10.0.0.1/24</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: set remote addr
fd00:1:1:1::1/64</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: Network config (local
-- remote):</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: ltp_ns_veth2 --
ltp_ns_veth1</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: 10.0.0.2/24 --
10.0.0.1/24</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: fd00:1:1:1::2/64 --
fd00:1:1:1::1/64</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TCONF: 'arp cmd doesn't
support IPv6, skipping test-case</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: Stress auto-creation
of NDISC cache entry</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: by pinging
'fd00:1:1:1::1' and deleting entry again</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TINFO: with 'ip neigh del
fd00:1:1:1::1 dev ltp_ns_veth2'</div>
</li>
<li style="margin: 0.5em 0px; padding: 0px; border: 0px; outline:
0px; font-size: 13.6px; background: transparent; list-style:
decimal outside; font-weight: normal; vertical-align: top;">
<div style="margin: 0px; padding: 0px; border: 0px; outline:
0px; font-size: 1em; background: none; font-style: normal;
font-variant: normal; font-weight: normal; font-stretch:
normal; line-height: 1.2em; font-family: monospace;
vertical-align: top;">ipneigh01 1 TPASS: verified
adding/removing of NDISC cache entry</div>
</li>
</ol>
Please correct me if I missing something but I read this like "ok we
can't run this test case because arp cmd doesn't support IPv6 , ah
but wait test case is passed ". <br>
<br>
After all discussions around that patch and all info which I gain I
can agree that changing TCONF with TINFO was bad idea , but if we
will just "fix" issue by changing TST_TOTAL value to 1 ( if I
correctly understand your suggestion ) <br>
this will not remove this confusion. <br>
<br>
Only valid fix which I see is change behavior of LTP to change test
case counter after TCONF which makes total sense for me , but most
probably I missing something and you had some reasons to not
changing counter on TCONF messages. Can you please elaborate them ?<br>
<pre class="moz-signature" cols="72">
--
Anton Smorodskyi <a class="moz-txt-link-rfc2396E" href="mailto:asmorodskyi@suse.com"><asmorodskyi@suse.com></a>
QA Engineer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755; <a class="moz-txt-link-freetext" href="https://www.suse.com/">https://www.suse.com/</a>
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)
</pre>
</body>
</html>