<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><font size="-1">Hi Petr, <br>
</font></p>
<p><font size="-1">Thanks for review !</font><br>
</p>
<br>
<blockquote type="cite"
cite="mid:20180516090947.nkoa6lhtu2rj4x52@dell5510">
<pre wrap="">I'm sorry to NACK your patch, there needs to be some changes to done.
Some change I'd like to have is to pass this script command (-c [ arp | ip ]) and run test
only once, i.e. TST_CNT=1 (then it does not need to be included).
Then in runtest files it'd be:
diff --git runtest/net.ipv6 runtest/net.ipv6
-ipneigh601 ipneigh01.sh -6
+ipneigh6_ip ipneigh01.sh -6 -c ip
diff --git runtest/net.tcp_cmds runtest/net.tcp_cmds
-ipneigh01 ipneigh01.sh
+ipneigh01_arp ipneigh01.sh -c arp
+ipneigh01_ip ipneigh01.sh -c ip
By this test is 1) cleaner 2) we get rid of TCONF for IPv6.</pre>
</blockquote>
<br>
ok , make sense . <br>
<br>
<blockquote type="cite"
cite="mid:20180516090947.nkoa6lhtu2rj4x52@dell5510">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">+ tst_res TCONF "'arp cmd doesn't support IPv6, skipping test-case"
</pre>
</blockquote>
<pre wrap="">You still do TCONF.</pre>
</blockquote>
Yes and it make perfect sense now because I am doing exit just after
this message , so it is ok<br>
<blockquote type="cite"
cite="mid:20180516090947.nkoa6lhtu2rj4x52@dell5510"><br>
<blockquote type="cite">
<pre wrap=""> ping$TST_IPV6 -q -c1 $rhost > /dev/null
</pre>
</blockquote>
<pre wrap="">It looks to me better using tst_ping() from tst_net.sh (API function, other tests use it).
Then we could get rid of checking in do_setup:
tst_check_cmds arp grep ping$TST_IPV6
</pre>
</blockquote>
ok , was not aware about that , will change this <br>
--
<pre class="moz-signature" cols="72">Anton Smorodskyi <a class="moz-txt-link-rfc2396E" href="mailto:asmorodskyi@suse.com"><asmorodskyi@suse.com></a>
QA Engineer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755; <a class="moz-txt-link-freetext" href="https://www.suse.com/">https://www.suse.com/</a>
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)
</pre>
</body>
</html>