<div dir="ltr"><div style="font-size:small" class="gmail_default"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 31, 2018 at 10:45 AM, Jinhui huang <span dir="ltr"><<a href="mailto:huangjh.jy@cn.fujitsu.com" target="_blank">huangjh.jy@cn.fujitsu.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">Compilation failed because of undefined EXTPROC on old distros(e.g. RHEL5/6).<br>
<br>
Based on the fix patch[1] and added EXTPROC, tcgetattr() still could not detect<br>
invalid EXTPROC on old distros. So we wanted to skip the case if EXTPROC was not<br>
defined on current distros.<br>
<br>
[1] <a rel="noreferrer" href="http://lists.linux.it/pipermail/ltp/2018-May/008253.html" target="_blank">http://lists.linux.it/pipermai<wbr>l/ltp/2018-May/008253.html</a><br>
<br>
Signed-off-by: Jinhui huang <<a href="mailto:huangjh.jy@cn.fujitsu.com" target="_blank">huangjh.jy@cn.fujitsu.com</a>><br>
---<br>
testcases/kernel/pty/pty02.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/testcases/kernel/pty/pty02.c b/testcases/kernel/pty/pty02.c<br>
index fd3d26b..548f8d1 100644<br>
--- a/testcases/kernel/pty/pty02.c<br>
+++ b/testcases/kernel/pty/pty02.c<br>
@@ -29,6 +29,8 @@<br>
<br>
#include "tst_test.h"<br>
<br>
+#ifdef EXTPROC<br></blockquote><div><br><div style="font-size:small" class="gmail_default">This fix is fine. But image that a distribution defined both EXTPROC and ICANON, if the ICANON(enables canonical input processing, also called <span class="m_2202741644696985867m_4008265290083520193gmail-ph m_2202741644696985867m_4008265290083520193gmail-synph"><span class="m_2202741644696985867m_4008265290083520193gmail-ph m_2202741644696985867m_4008265290083520193gmail-var m_2202741644696985867m_4008265290083520193gmail-ibm-item-note-alternate">line
mode</span></span>) needs newline('\n') to ptmx there, this test will hung there forever.<br></div><br> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
+<br>
static void do_test(void)<br>
{<br>
struct termios io = { .c_lflag = EXTPROC | ICANON };<br>
@@ -60,3 +62,7 @@ static void do_test(void)<br>
static struct tst_test test = {<br>
.test_all = do_test,<br>
};<br>
+<br>
+#else<br>
+ TST_TEST_TCONF("EXTPROC is not defined");<br>
+#endif<br>
<span class="m_2202741644696985867m_4008265290083520193gmail-m_3084795570503090825m_-1468398277269262761HOEnZb"><font color="#888888">-- <br>
1.8.3.1<br>
<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="m_2202741644696985867m_4008265290083520193gmail-m_3084795570503090825m_-1468398277269262761gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div>
</div></div>