<div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Eddie,</div><div class="gmail_extra"><br><div class="gmail_quote">Eddie Horng <span dir="ltr"><<a href="mailto:eddiehorng.tw@gmail.com" target="_blank">eddiehorng.tw@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-739389581308179105gmail-m_-2508501562173493479m_2010744153895661647gmail-">2018-08-01 19:17 GMT+08:00 Li Wang <<a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a>>:<br>
> why not adding other arches?<br>
><br>
> $ git grep __NR_execveat<br>
> alpha/include/uapi/asm/unistd.<wbr>h:#define __NR_execveat                   513<br>
> arm64/include/asm/unistd32.h:#<wbr>define __NR_<div class="gmail_default" style="font-size:small;display:inline"></div>execveat 387<br>
> arm64/include/asm/unistd32.h:_<wbr>_SYSCALL(__NR_execveat, compat_sys_execveat)<br>
<br>
</span>Hi Li,<br>
Thanks your tips on finding syscall id, but I still can't find all<br>
arches listed in<br>
[ltp]/include/lapi/syscalls from [kernel]/arch, should I just add the id as much<br>
as I can find from [kernel]/arch?<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">I think at least we'd better adding support as LTP(/include/lapi/syscalls) has.</div><div class="gmail_default" style="font-size:small"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-739389581308179105gmail-m_-2508501562173493479m_2010744153895661647gmail-">
<br>
</span>So Cryil's suggestion works for the case? Same EINVAL error for<br>
both verifying TCONF and expected TFAIL.<br><div class="gmail_default" style="font-size:small;display:inline"></div><br></blockquote><div><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_default" style="font-size:small">Hmm, from your patch I got these information:</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">kernel < 3.19    : <div class="gmail_default" style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline"></div><span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">execveat() not support</span></div></div><div class="gmail_default" style="font-size:small">3.19 <= kernel < 4.14  : <div class="gmail_default" style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline"></div><span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">execveat() fully support</span></div><div class="gmail_default" style="font-size:small">kernel >= 4.14  : <div class="gmail_default" style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline"></div><span style="background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">execveat() return EINVAL expectly</span></div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">If I was right, so Cyril's suggestion should be like:</div><div class="gmail_default"><br></div><div class="gmail_default">static void do_child(void)</div><div class="gmail_default">{</div><div class="gmail_default">    ...</div><div class="gmail_default">    </div><div class="gmail_default">    /* Check if system support execveat() correctly */</div><div class="gmail_default">    TEST(execveat(fd, "", argv, environ, AT_EMPTY_PATH));</div><div class="gmail_default">    /* Do TCONF if we get EINVAL here */</div><div class="gmail_default"><br></div><div class="gmail_default">    SAFE_UNLINK(TEST_FILE_PATH);</div><div class="gmail_default"><br></div><div class="gmail_default">    /* Do your testing */</div><div class="gmail_default">    TEST(execveat(fd, "", argv, environ, AT_EMPTY_PATH));</div><div class="gmail_default">    /* Here if we get EINVAL again that means hit a bug! */</div><div class="gmail_default">}<span style="font-size:small"></span></div><div class="gmail_default" style="font-size:small"></div><div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Did I miss anything? </div><br></div>-- <br><div class="m_-739389581308179105gmail-m_-2508501562173493479m_2010744153895661647gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div>
</div></div>