<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body smarttemplateinserted="true">
<div id="smartTemplate4-template">
<p>Hi Petr, <br>
</p>
</div>
<br>
<div id="smartTemplate4-quoteHeader">-------- Original Message --------<br>
From: Petr Vorel<br>
Sent: Wed, 10 Apr 2019 16:16:15 +0200<br>
To: Sandeep Patil, Steve Muckle<br>
Cc: Ltp, Zhengwang Ruan, Cyril Hrubis<br>
Subject: Re: [LTP] 回复：[PATCH v1] include/mk/env_post.mk : enable
__ANDROID__ definition for Android build<br>
</div>
<blockquote type="cite" cite="mid:20190410141615.GA10303@x230">
<pre class="moz-quote-pre" wrap="">Hi Sandeep, Steve,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Could anyone help me to review this patch? This is useful to cross-compile ltp for Android without specifying '-D__ANDROID__' in configure step.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Thanks!
Zhengwang
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">------------------------------------------------------------------
发件人：Zhengwang Ruan <a class="moz-txt-link-rfc2396E" href="mailto:ruanzw@xiaopeng.com"><ruanzw@xiaopeng.com></a>
发送时间：2019年4月9日(星期二) 12:05
收件人：ltp <a class="moz-txt-link-rfc2396E" href="mailto:ltp@lists.linux.it"><ltp@lists.linux.it></a>
抄 送：Zhengwang Ruan <a class="moz-txt-link-rfc2396E" href="mailto:ruanzw@xiaopeng.com"><ruanzw@xiaopeng.com></a>
主 题：[PATCH v1] include/mk/env_post.mk: enable __ANDROID__ definition for Android build
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Enable the __ANDROID__ definition by default for Android build, otherwise we
should manually enable it by configure command.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Zhengwang Ruan <a class="moz-txt-link-rfc2396E" href="mailto:ruanzw@xiaopeng.com"><ruanzw@xiaopeng.com></a>
---
include/mk/env_post.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">diff --git a/include/mk/env_post.mk b/include/mk/env_post.mk
index 913bdf5..7953e0a 100644
--- a/include/mk/env_post.mk
+++ b/include/mk/env_post.mk
@@ -44,7 +44,7 @@ endif
ifeq ($(ANDROID),1)
# There are many undeclared functions, it's best not to accidentally overlook
# them.
-CFLAGS += -Werror-implicit-function-declaration
+CFLAGS += -Werror-implicit-function-declaration -D__ANDROID__
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Would adding __ANDROID__ definition help building LTP with distro
cross-compiler? (i.e. no NDK, no inside AOSP tree)?
I guess so and therefore, I'd be for this change.
I see some projects added it as well (busybox [1] [2], dnsmasq [3]).
BTW: where is defined for AOSP and NDK?</pre>
</blockquote>
<p><br>
</p>
<p>I found that '-DANDROID' instead of '-D__ANDROID__' was passed
while cross-compiling binaries in my AOSP project.</p>
<p><br>
</p>
<p>Thanks!</p>
<p>Zhengwang<br>
</p>
<blockquote type="cite" cite="mid:20190410141615.GA10303@x230">
<pre class="moz-quote-pre" wrap="">
BTW (@cyril): I guess -Werror-implicit-function-declaration is the code which
requires adding <string.h> and <strings.h> (see my fix 4053a2551 ("lib: Add
missing <string.h> and <strings.h> includes")), I'd be for either adding it to
for all or removing it.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> LDFLAGS += -L$(top_builddir)/lib/android_libpthread
LDFLAGS += -L$(top_builddir)/lib/android_librt
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Kind regards,
Petr
[1] <a class="moz-txt-link-freetext" href="https://git.busybox.net/busybox/tree/configs/android_defconfig">https://git.busybox.net/busybox/tree/configs/android_defconfig</a>
[2] <a class="moz-txt-link-freetext" href="https://git.busybox.net/busybox/tree/configs/android_ndk_defconfig">https://git.busybox.net/busybox/tree/configs/android_ndk_defconfig</a>
[3] <a class="moz-txt-link-freetext" href="http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=blob_plain;f=bld/Android.mk;hb=HEAD">http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=blob_plain;f=bld/Android.mk;hb=HEAD</a>
</pre>
</blockquote>
</body>
</html>