<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body smarttemplateinserted="true">
<div id="smartTemplate4-template">
<p>Hi Cooper, <br>
</p>
</div>
<br>
<div id="smartTemplate4-quoteHeader">-------- Original Message --------<br>
From: Enji Cooper<br>
Sent: Thu, 11 Apr 2019 08:16:00 -0700<br>
To: Zhengwang Ruan<br>
Cc: Ltp<br>
Subject: Re: [LTP] [PATCH v1] Fix build error caused by
-Werror-implicit-function-declaration for Android<br>
</div>
<blockquote type="cite"
cite="mid:F2D8419F-5149-4D85-BBBC-53B268A38065@gmail.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Apr 11, 2019, at 07:18, Zhengwang Ruan <a class="moz-txt-link-rfc2396E" href="mailto:ruanzw@xiaopeng.com"><ruanzw@xiaopeng.com></a> wrote:
Fix build errors caused by -Werror-implicit-function-declaration by add missing
<string.h> and <strings.h> for Android.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Comment next time: it would be a good idea a to note what functions were missing.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Zhengwang Ruan <a class="moz-txt-link-rfc2396E" href="mailto:ruanzw@xiaopeng.com"><ruanzw@xiaopeng.com></a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Reviewed-by: Enji Cooper <a class="moz-txt-link-rfc2396E" href="mailto:yaneurabeya@gmail.com"><yaneurabeya@gmail.com></a>
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">---
include/tst_numa.h | 2 ++
include/tst_test.h | 1 +
testcases/kernel/syscalls/copy_file_range/copy_file_range01.c | 1 +
testcases/kernel/syscalls/epoll_ctl/epoll_ctl01.c | 2 +-
testcases/kernel/syscalls/epoll_wait/epoll_wait01.c | 1 +
5 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/tst_numa.h b/include/tst_numa.h
index a4cd1be..4f98066 100644
--- a/include/tst_numa.h
+++ b/include/tst_numa.h
@@ -7,6 +7,8 @@
#ifndef TST_NUMA_H__
#define TST_NUMA_H__
+#include <string.h>
+
/**
* Numa nodemap.
*/
diff --git a/include/tst_test.h b/include/tst_test.h
index cf2447f..25b9763 100644
--- a/include/tst_test.h
+++ b/include/tst_test.h
@@ -24,6 +24,7 @@
#include <unistd.h>
#include <limits.h>
+#include <string.h>
#include "tst_common.h"
#include "tst_res_flags.h"
diff --git a/testcases/kernel/syscalls/copy_file_range/copy_file_range01.c b/testcases/kernel/syscalls/copy_file_range/copy_file_range01.c
index 2bca8a4..61a6042 100644
--- a/testcases/kernel/syscalls/copy_file_range/copy_file_range01.c
+++ b/testcases/kernel/syscalls/copy_file_range/copy_file_range01.c
@@ -15,6 +15,7 @@
#define _GNU_SOURCE
#include <stdio.h>
#include <errno.h>
+#include <stdlib.h>
#include "tst_test.h"
#include "tst_safe_stdio.h"
#include "lapi/syscalls.h"
diff --git a/testcases/kernel/syscalls/epoll_ctl/epoll_ctl01.c b/testcases/kernel/syscalls/epoll_ctl/epoll_ctl01.c
index e837913..4df55b5 100644
--- a/testcases/kernel/syscalls/epoll_ctl/epoll_ctl01.c
+++ b/testcases/kernel/syscalls/epoll_ctl/epoll_ctl01.c
@@ -31,7 +31,7 @@
#include <sys/epoll.h>
#include <poll.h>
-#include <string.h>
+#include <strings.h>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Just a general question: did you test the non-Android case?</pre>
</blockquote>
<p>Yes, I have tested it using the default gcc on my Ubuntu 16.04
host.</p>
<p><br>
</p>
<p>Kind Regards,</p>
<p>Zhengwang<br>
</p>
<blockquote type="cite"
cite="mid:F2D8419F-5149-4D85-BBBC-53B268A38065@gmail.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">#include <errno.h>
#include "tst_test.h"
diff --git a/testcases/kernel/syscalls/epoll_wait/epoll_wait01.c b/testcases/kernel/syscalls/epoll_wait/epoll_wait01.c
index 0ded127..6099b84 100644
--- a/testcases/kernel/syscalls/epoll_wait/epoll_wait01.c
+++ b/testcases/kernel/syscalls/epoll_wait/epoll_wait01.c
@@ -26,6 +26,7 @@
#include <sys/epoll.h>
#include <poll.h>
#include <string.h>
+#include <strings.h>
#include <errno.h>
#include "tst_test.h"
--
2.7.4
--
Mailing list info: <a class="moz-txt-link-freetext" href="https://lists.linux.it/listinfo/ltp">https://lists.linux.it/listinfo/ltp</a>
</pre>
</blockquote>
</blockquote>
</body>
</html>