<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body smarttemplateinserted="true">
<div id="smartTemplate4-template">
<p>Hi Petr, <br>
</p>
</div>
<br>
<div id="smartTemplate4-quoteHeader">-------- Original Message --------<br>
From: Petr Vorel<br>
Sent: Fri, 12 Apr 2019 10:48:53 +0200<br>
To: Cyril Hrubis<br>
Cc: ?????????, Ltp, Petr Vorel, Sandeep Patil, Steve Muckle<br>
Subject: Re: [RFC PATCH 2/3] Add more missing <string.h> and
<strings.h> includes<br>
</div>
<blockquote type="cite" cite="mid:20190412084853.GB19937@x230">
<pre class="moz-quote-pre" wrap="">Hi,
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">diff --git a/include/tst_numa.h b/include/tst_numa.h
index a4cd1be37..4f9806602 100644
--- a/include/tst_numa.h
+++ b/include/tst_numa.h
@@ -7,6 +7,8 @@
#ifndef TST_NUMA_H__
#define TST_NUMA_H__
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+#include <string.h>
+
/**
* Numa nodemap.
*/
diff --git a/lib/tst_af_alg.c b/lib/tst_af_alg.c
index 97be548b4..edf8c0140 100644
--- a/lib/tst_af_alg.c
+++ b/lib/tst_af_alg.c
@@ -5,6 +5,7 @@
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap=""> #include <errno.h>
#include <stdlib.h>
+#include <string.h>
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Why not simply include <string.h>?? in tst_test.h. I did it in my another
review thread. This should be OK for most of cases.
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Sounds reasonable to me.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Agree, that'd be the easiest way :). NOTE: not sure what requires that, but
sometimes is <strings.h> needed as well.</pre>
</blockquote>
<p>As I know, calls likes str*, mem*, such as, strncpy, memset,
requires <string.h>, but bzero requires <strings.h>.
Fortunately <strings.h> are not used as often as
<string.h>. See my another review thread. :-)</p>
<p><br>
</p>
<p>Regards,</p>
<p>Zhengwang<br>
</p>
<blockquote type="cite" cite="mid:20190412084853.GB19937@x230">
<pre class="moz-quote-pre" wrap="">
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>