<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body smarttemplateinserted="true">
<div id="smartTemplate4-template">
<p>Hi Petr, Sandeep, Steve, <br>
</p>
</div>
<br>
<div id="smartTemplate4-quoteHeader">-------- Original Message --------<br>
From: Petr Vorel<br>
Sent: Thu, 11 Apr 2019 19:46:38 +0200<br>
To: Zhengwang Ruan, Steve Muckle, Sandeep Patil<br>
Cc: Ltp<br>
Subject: Re: [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace
definition ANDROID with __ANDROID__<br>
</div>
<blockquote type="cite" cite="mid:20190411174638.GA11576@dell5510">
<pre class="moz-quote-pre" wrap="">Hi,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Replace the incorrect definition of ANDROID with __ANDROID__.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+++ b/testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c
@@ -25,7 +25,7 @@
#include "tst_test.h"
#include "lapi/syscalls.h"
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">-#ifndef ANDROID
+#ifndef __ANDROID__
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Simple grep in AOSP tree would be for this change (and I'd personally prefer it as well)
I'd kindly ask android devs which one is correct :). BTW ANDROID was added by Steve.</pre>
</blockquote>
<p>According to also [1], this patch is acceptable, right?</p>
<blockquote type="cite" cite="mid:20190411174638.GA11576@dell5510">
<pre class="moz-quote-pre" wrap="">
$ cgrep '#if.* __ANDROID__' |wc -l
405
$ cgrep '#if.* ANDROID[^_]' |wc -l
22
Kind regards,
Petr
</pre>
</blockquote>
<p>Regards,</p>
<p>Zhengwang</p>
<p>[1]
<a class="moz-txt-link-freetext" href="https://groups.google.com/forum/#!topic/android-ndk/cf9_f1SLXls">https://groups.google.com/forum/#!topic/android-ndk/cf9_f1SLXls</a><br>
</p>
</body>
</html>