<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 12, 2019, at 2:05 AM, 阮正旺 <<a href="mailto:ruanzw@xiaopeng.com" class="">ruanzw@xiaopeng.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div smarttemplateinserted="true" class="">
<div id="smartTemplate4-template" class=""><p class="">Hi Petr, <br class="">
</p>
</div>
<br class="">
<div id="smartTemplate4-quoteHeader" class="">-------- Original Message --------<br class="">
From: Petr Vorel<br class="">
Sent: Fri, 12 Apr 2019 10:48:53 +0200<br class="">
To: Cyril Hrubis<br class="">
Cc: ?????????, Ltp, Petr Vorel, Sandeep Patil, Steve Muckle<br class="">
Subject: Re: [RFC PATCH 2/3] Add more missing <string.h> and
<strings.h> includes<br class="">
</div>
<blockquote type="cite" cite="mid:20190412084853.GB19937@x230" class="">
<pre class="moz-quote-pre" wrap="">Hi,
</pre>
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<pre class="moz-quote-pre" wrap="">diff --git a/include/tst_numa.h b/include/tst_numa.h
index a4cd1be37..4f9806602 100644
--- a/include/tst_numa.h
+++ b/include/tst_numa.h
@@ -7,6 +7,8 @@
#ifndef TST_NUMA_H__
#define TST_NUMA_H__
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap=""></pre>
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<pre class="moz-quote-pre" wrap="">+#include <string.h>
+
/**
* Numa nodemap.
*/
diff --git a/lib/tst_af_alg.c b/lib/tst_af_alg.c
index 97be548b4..edf8c0140 100644
--- a/lib/tst_af_alg.c
+++ b/lib/tst_af_alg.c
@@ -5,6 +5,7 @@
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap=""></pre>
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<pre class="moz-quote-pre" wrap=""> #include <errno.h>
#include <stdlib.h>
+#include <string.h>
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap=""></pre>
<blockquote type="cite" class="">
<blockquote type="cite" class="">
<pre class="moz-quote-pre" wrap="">Why not simply include <string.h>?? in tst_test.h. I did it in my another
review thread. This should be OK for most of cases.
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap=""></pre>
<blockquote type="cite" class="">
<pre class="moz-quote-pre" wrap="">Sounds reasonable to me.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Agree, that'd be the easiest way :). NOTE: not sure what requires that, but
sometimes is <strings.h> needed as well.</pre>
</blockquote><p class="">As I know, calls likes str*, mem*, such as, strncpy, memset,
requires <string.h>, but bzero requires <strings.h>.
Fortunately <strings.h> are not used as often as
<string.h>. See my another review thread. :-)</p></div></div></blockquote></div><div>(Looking at the header on FreeBSD) In addition to bzero, there are other deprecated functions like bcmp, bcopy, but also lesser used functions like strcasecmp and strncasecmp which are defined in strings.h .</div><div>Cheers,</div><div>-Enji</div></body></html>