<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body smarttemplateinserted="true">
<div id="smartTemplate4-template">
<p>Hi Steve, Petr, Sandeep,<br>
</p>
</div>
<br>
<div id="smartTemplate4-quoteHeader">-------- Original Message --------<br>
From: Steve Muckle<br>
Sent: Wed, 24 Apr 2019 12:27:32 -0700<br>
To: Zhengwang Ruan, Ltp, Petr Vorel, Sandeep Patil<br>
Cc: <br>
Subject: Re: [PATCH v2] include/mk/env_post.mk: enable __ANDROID__
definition for Android build<br>
</div>
<blockquote type="cite"
cite="mid:15aeaa52-eecc-e21a-eb86-d66cfe81928e@google.com">On
4/24/19 9:55 AM, Zhengwang Ruan wrote:
<br>
<blockquote type="cite">The definition of __ANDROID__ has been
widely used to compile android-specific
<br>
things (i.e. busybox [1] [2], dnsmasq [3]), so we expected NDK
to automatically
<br>
pass it to help build LTP for android, but unfortunately it
didn't (it is tested
<br>
with android-ndk-r19c). Currently, we have to manually specify
-D__ANDROID__ in
<br>
configure step before launch 'make ANDROID=1' command, and this
is suffering for
<br>
those who don't have good knowledge of LTP, so it is necessary
to enable it if
<br>
built for android.
<br>
</blockquote>
<br>
Hi Zhengwang I mentioned in the other thread but just to get it
here also, __ANDROID__ seems to be defined for me by the NDK.
Could you try the steps Sandeep shared?
<br>
</blockquote>
<p>Yes, I tried. And it proves NDK has defined it, and this patch is
not needed.<br>
</p>
<p>Thank you guys very much for your time and helping me review
this.</p>
<p>--<br>
</p>
<p>Kind Regards,</p>
<p>Zhengwang<br>
</p>
<blockquote type="cite"
cite="mid:15aeaa52-eecc-e21a-eb86-d66cfe81928e@google.com">
<br>
thanks,
<br>
steve
<br>
</blockquote>
</body>
</html>