<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 18, 2019 at 5:46 AM Petr Vorel <<a href="mailto:pvorel@suse.cz">pvorel@suse.cz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Li,<br>
<br>
> Testcases for specified arch should be limited on that only being supported<br>
> platform to run, we now create a function tst_on_arch to achieve this new<br>
> feature in LTP library. All you need to run a test on the expected arch is<br>
> to set the '.arch' string in the 'struct tst_test' to choose the required<br>
> arch list. e.g. '.arch = "x86_64 i386"'.<br>
<br>
> Signed-off-by: Li Wang <<a href="mailto:liwang@redhat.com" target="_blank">liwang@redhat.com</a>><br>
Reviewed-by: Petr Vorel <<a href="mailto:pvorel@suse.cz" target="_blank">pvorel@suse.cz</a>><br>
<br>
LGTM. FYI there is also HOST_CPU variable (since 00ff2c348f),<br>
but that does not help your patch.<br>
<br>
> ---<br>
> doc/test-writing-guidelines.txt | 26 ++++++++++<br>
> include/tst_arch.h | 16 ++++++<br>
> include/tst_test.h | 7 ++-<br>
> lib/tst_arch.c | 92 +++++++++++++++++++++++++++++++++<br>
> 4 files changed, 140 insertions(+), 1 deletion(-)<br>
> create mode 100644 include/tst_arch.h<br>
> create mode 100644 lib/tst_arch.c<br>
<br>
> diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt<br>
> index f1912dc12..b4fba0190 100644<br>
> --- a/doc/test-writing-guidelines.txt<br>
> +++ b/doc/test-writing-guidelines.txt<br>
> @@ -1668,6 +1668,32 @@ sturct tst_test test = {<br>
> };<br>
> -------------------------------------------------------------------------------<br>
<br>
> +2.2.30 Testing on specified architecture<br>
^ maybe specific?<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Agree.</div><div class="gmail_default" style="font-size:small"><br></div></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>