<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 11, 2019 at 9:03 PM Clemens Famulla-Conrad <<a href="mailto:cfamullaconrad@suse.de">cfamullaconrad@suse.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, 2019-10-11 at 12:06 +0200, Petr Vorel wrote:<br>
> Hi,<br>
> <br>
> Cc: Li and Clemens<br>
> <br>
> > these patches rename tst_test_* to tst_require_*, to better<br>
> > describe<br>
> > their use. There is also tst_require_root, that has the same<br>
> > behavior: It also calls tst_brk in case of a failing requirement.<br>
> > You can also get this patch from the following repo:<br>
> > <a href="https://github.com/MofX/ltp/commits/rename_tst_test-tst_require" rel="noreferrer" target="_blank">https://github.com/MofX/ltp/commits/rename_tst_test-tst_require</a><br>
> <br>
> sorry for not thinking first, I wonder if we want to sync<br>
> tst_test_* (function name) vs $TST_NEEDS_* (test API variable name),<br>
> e.g.: tst_require_drivers $TST_NEEDS_DRIVERS<br>
<br>
I fully agree with Petr that we must be consistent in naming between<br>
variable- and function-name.<br></blockquote><div> </div><div><span class="gmail_default" style="font-size:small">+1</span></div><div><span class="gmail_default" style="font-size:small"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> <br>
> i.e. either of these:<br>
> s/tst_test_/tst_needs_/<br>
> s/TST_NEEDS_/TST_REQUIRE_/<br>
> <br>
> I consider *require* as more descriptive than *needs*,<br>
> but changing to *require* would require more work :).<br>
<br>
If we use needs or require ? Hard question - when I search for synonyms<br>
from one or the other, I don't see a big different. Without looking on<br>
the impact, require sounds also more descriptive.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Yes, I have the same feeling here.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">FYI:</div><div class="gmail_default" style="font-size:small">  needs: because it's important</div><div class="gmail_default" style="font-size:small">  require: because it's a necessity</div><br></div><div class="gmail_default" style="font-size:small"><a href="https://www.englishcurrent.com/grammar/difference-need-require-verbs/">https://www.englishcurrent.com/grammar/difference-need-require-verbs/</a></div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>