<div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Cyril Hrubis <<a href="mailto:chrubis@suse.cz">chrubis@suse.cz</a>> wrote:<br></div><div dir="ltr" class="gmail_attr"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-size:small">...</span><br>
+static void print_failure_hints(void)<br>
+{<br>
+       unsigned int i;<br>
+       const struct tst_tag *tags = tst_test->tags;<br>
+<br>
+       if (!tags)<br>
+               return;<br>
+<br>
+       int hint_printed = 0;<br>
+       for (i = 0; tags[i].name; i++) {<br>
+               if (!strcmp(tags[i].name, "linux-git")) {<br>
+                       if (!hint_printed) {<br>
+                               hint_printed = 1;<br>
+                               printf("\n");<br>
+                               print_colored("HINT: ");<br>
+                               printf("You _MAY_ be missing kernel fixes, see:\n\n");<br>
+                       }<br>
+<br>
+                       printf(LINUX_GIT_URL "%s\n", tags[i].value);<br>
+               }<br>
+<br>
+       }<br>
+<br>
+       hint_printed = 0;<br>
+       for (i = 0; tags[i].name; i++) {<br>
+               if (!strcmp(tags[i].name, "CVE")) {<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Maybe we can merge this string compare in the same for loops?</div></div><div><div class="gmail_default" style="font-size:small"><br></div></div><div><div class="gmail_default" style="font-size:small">e.g: <a href="http://pastebin.test.redhat.com/808028">http://pastebin.test.redhat.com/808028</a></div></div><div> </div></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div></div>