<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Joerg,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Nov 14, 2019 at 2:31 PM Joerg Vehlow <<a href="mailto:lkml@jv-coder.de">lkml@jv-coder.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-size:small">...</span><br>
> From the original intention, it likely to set yes as the default, so <br>
> maybe the [action-if-not-given] should as  [with_expect=yes]?<br>
Maybe, but I did not want to change the current behavior here. This <br>
should be done in another patch.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Ok, sure.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
><br>
><br>
>     -# testcases/realtime requires bash and python.<br>
>     -if test "x$with_bash" = xyes && test "x$with_python" = xyes; then<br>
>     -    AC_ARG_WITH([realtime-testsuite],<br>
>     -      [AC_HELP_STRING([--with-realtime-testsuite],<br>
>     -        [compile and install the realtime testsuite (default=no)])],<br>
>     -      [with_realtime_testsuite=yes]<br>
>     -    )<br>
>     -fi<br>
>     +# TODO: testcases/realtime requires bash and python.<br>
><br>
><br>
> Why remove the judgment of bash/python here?<br>
It simply does not work as intended. See last part of my patch description:<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Ah, sorry for missing this part.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Defining AC_ARG_WITH within an if to express dependencies does not work.<br>
./configure --with-realtime-testsuite set with_realtime_testsuite=yes,<br>
even if with_bash=no or with_python=no. The check is removed completely.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Or, maybe we can make use of AS_IF here? and I noticed there are many places that use "if test ..." in the <a href="http://configure.ac">configure.ac</a> file. That looks tangly...</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I though removing it is better than leaving something that does nothing <br>
anyway<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Indeed.</div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>