<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=GBK">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">
<pre>on 2019/11/21 13:10, Petr Vorel wrote:</pre>
</div>
<blockquote type="cite" cite="mid:20191121051022.GA59487@x230">
<pre class="moz-quote-pre" wrap="">Hi Xu,
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ general question: do we want always test against kernel headers or libc
headers? Libc is often outdated, so mostly it'd be our fallback to be tested.
Ideally both kernel and libc header should be tested, but that's not easily
achievable.
</pre>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">IMHO, We often test libc and it usually includes kernel headers ie.
<sys/quota.h> <sys/prctl.h>. I perfet to check one except that glibc and
kernel they have themselves implementation . If the struct or variable is
not defined, we can define it in ltp lapi headers. Then we can avoid build
error and increase coverage(because kernel may implement it).
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Yep. I'm ok with using libc headers (increased coverage), but we need good
checks anyway for other libc (at least for musl; bionic also like glibc uses
internally kernel headers, uclibc-ng usually embeds kernel header parts and
strives to be glibc compatible anyway).</pre>
</blockquote>
<pre>Hi Petr
Yes. I check <sys/quota.h> and <sys/prctl.h> on musl libc[1] and they don't include linux header files.
So I think checking both kernel and libc headers on other libc(musl,bionic) is meaningful.
ps: If our travis-ci has a target with musl, I think it will be better. I don't know whether possible.
[1]<a class="moz-txt-link-freetext" href="http://git.musl-libc.org/cgit/musl/tree/include/sys/quota.h">http://git.musl-libc.org/cgit/musl/tree/include/sys/quota.h</a>
Thanks
Yang Xu
</pre>
<blockquote type="cite" cite="mid:20191121051022.GA59487@x230">
<pre class="moz-quote-pre" wrap="">
Kind regards,
Petr
</pre>
</blockquote>
</body>
</html>