<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 31, 2019 at 4:11 AM Petr Vorel <<a href="mailto:petr.vorel@gmail.com" target="_blank">petr.vorel@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">authdes is by default compiled out in libtirpc 1.2.5, thus<br>
authdes_create() returns NULL (see libtirpc commit bf8f0b8 Add back the<br>
authdes interfaces) and IMHO there is no way to detect whether libtirpc<br>
was compiled without authdes support to skip the test.<br></blockquote><div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Maybe uses m4 can detect if authdes_seccreate() support or not, similar to ltp commit 5bec81cd8550.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">But I also think to remove these tests is a better option. ACK from my side.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Interface to authdes_seccreate() is missing when libtirpc is compiled<br>
without authdes, thus compilation fail:<br>
<br>
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /tmp/ccFanCMm.o: in function `main':<br>
testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c:55: undefined reference to `authdes_seccreate'<br>
<br>
Signed-off-by: Petr Vorel <<a href="mailto:petr.vorel@gmail.com" target="_blank">petr.vorel@gmail.com</a>><br></blockquote><div><span class="gmail_default" style="font-size:small">Acked-by: Li Wang <<a href="mailto:liwang@redhat.com">liwang@redhat.com</a>></span></div><div><span class="gmail_default" style="font-size:small"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
Hi,<br>
<br>
or is it safe to expect that authdes is compiled out when authdes_create() returning NULL?<br>
I also decided to remove tests because authdes is deprecated and uClibc<br>
and musl does not provide DES authentication.<br>
<br>
FYI I've sent patch to libtirpc to add authdes_seccreate() interface [1].<br>
<br>
[1] <a href="https://sourceforge.net/p/libtirpc/mailman/message/36889142/" rel="noreferrer" target="_blank">https://sourceforge.net/p/libtirpc/mailman/message/36889142/</a><br>
<br>
runtest/net.tirpc_tests | 2 -<br>
testcases/network/rpc/rpc-tirpc/.gitignore | 2 -<br>
.../tirpc/tirpc_auth_authdes_create/Makefile | 23 -------<br>
.../tirpc_auth_authdes_create/assertions.xml | 5 --<br>
.../tirpc_authdes_create.c | 60 -----------------<br>
.../tirpc_auth_authdes_seccreate/Makefile | 23 -------<br>
.../assertions.xml | 5 --<br>
.../tirpc_authdes_seccreate.c | 65 -------------------<br>
8 files changed, 185 deletions(-)<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/Makefile<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/assertions.xml<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/tirpc_authdes_create.c<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/Makefile<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/assertions.xml<br>
delete mode 100644 testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c<br>
<br>
diff --git a/runtest/net.tirpc_tests b/runtest/net.tirpc_tests<br>
index ba967492f..48e9ba3f5 100644<br>
--- a/runtest/net.tirpc_tests<br>
+++ b/runtest/net.tirpc_tests<br>
@@ -4,8 +4,6 @@ tirpc_rpcb_getmaps rpc_test.sh -s tirpc_svc_3 -c tirpc_rpcb_getmaps<br>
tirpc_authnone_create rpc_test.sh -c tirpc_authnone_create<br>
tirpc_authsys_create rpc_test.sh -s tirpc_svc_1 -c tirpc_authsys_create<br>
tirpc_authsys_create_default rpc_test.sh -c tirpc_authsys_create_default<br>
-tirpc_authdes_create rpc_test.sh -s tirpc_svc_1 -c tirpc_authdes_create<br>
-tirpc_authdes_seccreate rpc_test.sh -s tirpc_svc_1 -c tirpc_authdes_seccreate<br>
<br>
tirpc_clnt_dg_create rpc_test.sh -s tirpc_svc_5 -c tirpc_clnt_dg_create<br>
tirpc_svc_dg_create rpc_test.sh -c tirpc_svc_dg_create<br>
diff --git a/testcases/network/rpc/rpc-tirpc/.gitignore b/testcases/network/rpc/rpc-tirpc/.gitignore<br>
index adcd81104..15b7c4d9c 100644<br>
--- a/testcases/network/rpc/rpc-tirpc/.gitignore<br>
+++ b/testcases/network/rpc/rpc-tirpc/.gitignore<br>
@@ -140,7 +140,6 @@<br>
/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_rmtcall/tirpc_rpcb_rmtcall_mt<br>
/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_rmtcall/tirpc_rpcb_rmtcall_performance<br>
/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_rmtcall/tirpc_rpcb_rmtcall<br>
-/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate<br>
/tests_pack/rpc_suite/tirpc/tirpc_expertlevel_rpcb_set/tirpc_rpcb_set<br>
/tests_pack/rpc_suite/tirpc/tirpc_err_svcerr_weakauth/tirpc_svcerr_weakauth<br>
/tests_pack/rpc_suite/tirpc/tirpc_err_svcerr_systemerr/tirpc_svcerr_systemerr<br>
@@ -176,7 +175,6 @@<br>
/tests_pack/rpc_suite/tirpc/tirpc_interlevel_clnt_control/tirpc_clnt_control<br>
/tests_pack/rpc_suite/tirpc/tirpc_interlevel_clnt_control/tirpc_clnt_control_limits<br>
/tests_pack/rpc_suite/tirpc/tirpc_interlevel_clnt_tp_create/tirpc_clnt_tp_create<br>
-/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/tirpc_authdes_create<br>
/tests_pack/rpc_suite/tirpc/tirpc_interlevel_svc_tp_create/tirpc_svc_tp_create<br>
/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_create_timed/tirpc_clnt_create_timed<br>
/tests_pack/rpc_suite/tirpc/tirpc_toplevel_clnt_create_timed/tirpc_clnt_create_timed_limits<br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/Makefile b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/Makefile<br>
deleted file mode 100644<br>
index 23bf048f0..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/Makefile<br>
+++ /dev/null<br>
@@ -1,23 +0,0 @@<br>
-#<br>
-# Copyright (C) 2014, Oracle and/or its affiliates. All Rights Reserved.<br>
-#<br>
-# This program is free software; you can redistribute it and/or modify<br>
-# it under the terms of the GNU General Public License as published by<br>
-# the Free Software Foundation; either version 2 of the License, or<br>
-# (at your option) any later version.<br>
-#<br>
-# This program is distributed in the hope that it will be useful,<br>
-# but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
-# GNU General Public License for more details.<br>
-#<br>
-# You should have received a copy of the GNU General Public License along<br>
-# with this program; if not, write to the Free Software Foundation, Inc.,<br>
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.<br>
-#<br>
-<br>
-top_srcdir ?= ../../../../../../../..<br>
-<br>
-include $(top_srcdir)/include/mk/<a href="http://env_pre.mk" rel="noreferrer" target="_blank">env_pre.mk</a><br>
-include $(abs_srcdir)/../../../Makefile.inc<br>
-include $(top_srcdir)/include/mk/<a href="http://generic_leaf_target.mk" rel="noreferrer" target="_blank">generic_leaf_target.mk</a><br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/assertions.xml b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/assertions.xml<br>
deleted file mode 100644<br>
index 927fdbbfb..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/assertions.xml<br>
+++ /dev/null<br>
@@ -1,5 +0,0 @@<br>
-<assertions><br>
- <assertion id="1" tag="ef:XSH6TC2:3966:3967"><br>
- Basic call of TIRPC authdes_create() function<br>
- </assertion><br>
-</assertions><br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/tirpc_authdes_create.c b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/tirpc_authdes_create.c<br>
deleted file mode 100644<br>
index bd52f5c0f..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_create/tirpc_authdes_create.c<br>
+++ /dev/null<br>
@@ -1,60 +0,0 @@<br>
-/*<br>
-* Copyright (c) Bull S.A. 2007 All Rights Reserved.<br>
-*<br>
-* This program is free software; you can redistribute it and/or modify it<br>
-* under the terms of version 2 of the GNU General Public License as<br>
-* published by the Free Software Foundation.<br>
-*<br>
-* This program is distributed in the hope that it would be useful, but<br>
-* WITHOUT ANY WARRANTY; without even the implied warranty of<br>
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.<br>
-*<br>
-* Further, this software is distributed without any warranty that it is<br>
-* free of the rightful claim of any third person regarding infringement<br>
-* or the like. Any license provided herein, whether implied or<br>
-* otherwise, applies only to this software file. Patent licenses, if<br>
-* any, provided herein do not apply to combinations of this program with<br>
-* other software, or any other product whatsoever.<br>
-*<br>
-* You should have received a copy of the GNU General Public License along<br>
-* with this program; if not, write the Free Software Foundation, Inc.,<br>
-* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.<br>
-*<br>
-* History:<br>
-* Created by: Cyril Lacabanne (<a href="mailto:Cyril.Lacabanne@bull.net" target="_blank">Cyril.Lacabanne@bull.net</a>)<br>
-*<br>
-*/<br>
-<br>
-#include <stdio.h><br>
-#include <stdlib.h><br>
-#include <time.h><br>
-#include <netdb.h><br>
-#include "lapi/rpc.h"<br>
-<br>
-//Standard define<br>
-#define PROCNUM 1<br>
-#define VERSNUM 1<br>
-<br>
-int main(int argn, char *argc[])<br>
-{<br>
- //Program parameters : argc[1] : HostName or Host IP<br>
- // argc[2] : Server Program Number<br>
- // other arguments depend on test case<br>
-<br>
- int test_status = 1; //Default test result set to FAILED<br>
- AUTH *authDes = NULL;<br>
- struct sockaddr server_addr;<br>
-<br>
- //Initialization<br>
-<br>
- authDes = authdes_create(argc[1], 60, &server_addr, NULL);<br>
-<br>
- //If we are here, macro call was successful<br>
- test_status = ((AUTH *) authDes != NULL) ? 0 : 1;<br>
-<br>
- //This last printf gives the result status to the tests suite<br>
- //normally should be 0: test has passed or 1: test has failed<br>
- printf("%d\n", test_status);<br>
-<br>
- return test_status;<br>
-}<br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/Makefile b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/Makefile<br>
deleted file mode 100644<br>
index 23bf048f0..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/Makefile<br>
+++ /dev/null<br>
@@ -1,23 +0,0 @@<br>
-#<br>
-# Copyright (C) 2014, Oracle and/or its affiliates. All Rights Reserved.<br>
-#<br>
-# This program is free software; you can redistribute it and/or modify<br>
-# it under the terms of the GNU General Public License as published by<br>
-# the Free Software Foundation; either version 2 of the License, or<br>
-# (at your option) any later version.<br>
-#<br>
-# This program is distributed in the hope that it will be useful,<br>
-# but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
-# GNU General Public License for more details.<br>
-#<br>
-# You should have received a copy of the GNU General Public License along<br>
-# with this program; if not, write to the Free Software Foundation, Inc.,<br>
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.<br>
-#<br>
-<br>
-top_srcdir ?= ../../../../../../../..<br>
-<br>
-include $(top_srcdir)/include/mk/<a href="http://env_pre.mk" rel="noreferrer" target="_blank">env_pre.mk</a><br>
-include $(abs_srcdir)/../../../Makefile.inc<br>
-include $(top_srcdir)/include/mk/<a href="http://generic_leaf_target.mk" rel="noreferrer" target="_blank">generic_leaf_target.mk</a><br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/assertions.xml b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/assertions.xml<br>
deleted file mode 100644<br>
index a19e4c1f2..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/assertions.xml<br>
+++ /dev/null<br>
@@ -1,5 +0,0 @@<br>
-<assertions><br>
- <assertion id="1" tag="ef:XSH6TC2:3966:3967"><br>
- Basic call of TIRPC authdes_seccreate() function<br>
- </assertion><br>
-</assertions><br>
diff --git a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c<br>
deleted file mode 100644<br>
index 87b07ec54..000000000<br>
--- a/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c<br>
+++ /dev/null<br>
@@ -1,65 +0,0 @@<br>
-/*<br>
-* Copyright (c) Bull S.A. 2007 All Rights Reserved.<br>
-*<br>
-* This program is free software; you can redistribute it and/or modify it<br>
-* under the terms of version 2 of the GNU General Public License as<br>
-* published by the Free Software Foundation.<br>
-*<br>
-* This program is distributed in the hope that it would be useful, but<br>
-* WITHOUT ANY WARRANTY; without even the implied warranty of<br>
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.<br>
-*<br>
-* Further, this software is distributed without any warranty that it is<br>
-* free of the rightful claim of any third person regarding infringement<br>
-* or the like. Any license provided herein, whether implied or<br>
-* otherwise, applies only to this software file. Patent licenses, if<br>
-* any, provided herein do not apply to combinations of this program with<br>
-* other software, or any other product whatsoever.<br>
-*<br>
-* You should have received a copy of the GNU General Public License along<br>
-* with this program; if not, write the Free Software Foundation, Inc.,<br>
-* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.<br>
-*<br>
-* History:<br>
-* Created by: Cyril Lacabanne (<a href="mailto:Cyril.Lacabanne@bull.net" target="_blank">Cyril.Lacabanne@bull.net</a>)<br>
-*<br>
-*/<br>
-<br>
-#include <stdio.h><br>
-#include <stdlib.h><br>
-#include <time.h><br>
-#include <netdb.h><br>
-#include "lapi/rpc.h"<br>
-<br>
-//Standard define<br>
-#define PROCNUM 1<br>
-#define VERSNUM 1<br>
-<br>
-int main(int argn, char *argc[])<br>
-{<br>
- //Program parameters : argc[1] : HostName or Host IP<br>
- // argc[2] : Server Program Number<br>
- // other arguments depend on test case<br>
-<br>
- //run_mode can switch into stand alone program or program launch by shell script<br>
- //1 : stand alone, debug mode, more screen information<br>
- //0 : launch by shell script as test case, only one printf -> result status<br>
- int run_mode = 0;<br>
- int test_status = 1; //Default test result set to FAILED<br>
- int progNum = atoi(argc[2]);<br>
- AUTH *authDes = NULL;<br>
- struct sockaddr server_addr;<br>
-<br>
- //Initialization<br>
-<br>
- authDes = authdes_seccreate(argc[1], 60, (char *)&server_addr, NULL);<br>
-<br>
- //If we are here, macro call was successful<br>
- test_status = ((AUTH *) authDes != NULL) ? 0 : 1;<br>
-<br>
- //This last printf gives the result status to the tests suite<br>
- //normally should be 0: test has passed or 1: test has failed<br>
- printf("%d\n", test_status);<br>
-<br>
- return test_status;<br>
-}<br>
-- <br>
2.24.0<br>
<br>
<br>
-- <br>
Mailing list info: <a href="https://lists.linux.it/listinfo/ltp" rel="noreferrer" target="_blank">https://lists.linux.it/listinfo/ltp</a><br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>