<html>Similar to the situation in patch 1, you wrote:<br /><br />+ struct rtc_time rtc_set_alarm = {13, 35, 12};<br /><br />In my opinion, this way of setting structure should be avoided.<br /><br />Thanks,<br />Aleksandar<br /><br />-------- Original Message --------<br />Subject: [LTP] [PATCH 2/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to read and set RTC alarm time<br />Date: Wednesday, April 22, 2020 17:28 CEST<br />From: Filip Bozuta <fbozuta1@gmail.com><br />To: ltp@lists.linux.it<br />CC: pvorel@suse.cz, Aleksandar.Markovic@rt-rk.com, laurent@vivier.eu<br />References: <20200422152841.13432-1-fbozuta1@gmail.com><br /><br /><br /> <blockquote type="cite" cite="20200422152841.13432-3-fbozuta1@gmail.com"><br />This patch tests functionalities of following ioctls:<br /><br />RTC_ALM_READ, RTC_ALM_SET - Getting/Setting alarm time<br /><br />Read and set the alarm time, for RTCs that support alarms.<br />The alarm interrupt must be separately enabled or disabled<br />using the RTC_AIE_ON, RTC_AIE_OFF requests. The third ioctl's<br />argument is a pointer to a rtc_time structure. Only the tm_sec,<br />tm_min, and tm_hour fields of this structure are used.<br /><br />Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com><br />---<br />runtest/syscalls | 1 +<br />testcases/kernel/syscalls/ioctl/.gitignore | 1 +<br />testcases/kernel/syscalls/ioctl/ioctl_rtc02.c | 107 ++++++++++++++++++<br />3 files changed, 109 insertions(+)<br />create mode 100644 testcases/kernel/syscalls/ioctl/ioctl_rtc02.c<br /> </blockquote><br /><br /><br /> </html>