<html>I thinks these lines:<br /><br />+static int interrupt_requests[] = {<br />+ RTC_AIE_ON, RTC_PIE_ON, RTC_UIE_ON,<br />+ RTC_WIE_ON, RTC_AIE_OFF, RTC_PIE_OFF,<br />+ RTC_UIE_OFF, RTC_WIE_OFF};<br />+static char requests_text[][15] = {<br />+ "RTC_AIE_ON", "RTC_PIE_ON", "RTC_UIE_ON",<br />+ "RTC_WIE_ON", "RTC_AIE_OFF", "RTC_PIE_OFF",<br />+ "RTC_UIE_OFF", "RTC_WIE_OFF"};<br /><br />would look much clearer as:<br /><br />static int interrupt_requests[] = {<br /> RTC_AIE_ON, RTC_PIE_ON, RTC_UIE_ON, RTC_WIE_ON,<br /> RTC_AIE_OFF, RTC_PIE_OFF, RTC_UIE_OFF, RTC_WIE_OFF};<br />static char requests_text[][15] = {<br /> "RTC_AIE_ON", "RTC_PIE_ON", "RTC_UIE_ON", "RTC_WIE_ON",<br /> "RTC_AIE_OFF", "RTC_PIE_OFF", "RTC_UIE_OFF", "RTC_WIE_OFF"};<br /><br />Thanks, Aleksandar<br /><br />P. S. (my email client doesn't handle tabs well (converts them to spaces) - ofcourse, you keep tabs, I em not suggesting replacing them with space)<br /><br /><br />-------- Original Message --------<br />Subject: [LTP] [PATCH 3/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to turn on/off RTC interrupts<br />Date: Wednesday, April 22, 2020 17:28 CEST<br />From: Filip Bozuta <fbozuta1@gmail.com><br />To: ltp@lists.linux.it<br />CC: pvorel@suse.cz, Aleksandar.Markovic@rt-rk.com, laurent@vivier.eu<br />References: <20200422152841.13432-1-fbozuta1@gmail.com><br /><br /><br /> <blockquote type="cite" cite="20200422152841.13432-4-fbozuta1@gmail.com"><br />This patch tests functionalities of following ioctls:<br /><br />RTC_AIE_ON, RTC_AIE_OFF - Alarm interrupt enabling on/off<br /><br />Enable or disable the alarm interrupt, for RTCs that support<br />alarms. The third ioctl's argument is ignored.<br /><br />RTC_UIE_ON, RTC_UIE_OFF - Update interrupt enabling on/off<br /><br />Enable or disable the interrupt on every clock update, for<br />RTCs that support this once-per-second interrupt. The third<br />ioctl's argument is ignored.<br /><br />RTC_PIE_ON, RTC_PIE_OFF - Periodic interrupt enabling on/off<br /><br />Enable or disable the periodic interrupt, for RTCs that sup‐<br />port these periodic interrupts. The third ioctl's argument<br />is ignored. Only a privileged process (i.e., one having the<br />CAP_SYS_RESOURCE capability) can enable the periodic interrupt<br />if the frequency is currently set above the value specified in<br />/proc/sys/dev/rtc/max-user-freq.<br /><br />RTC_WIE_ON, RTC_WIE_OFF - Watchdog interrupt enabling on/off<br /><br />Enable or disable the Watchdog interrupt, for RTCs that sup-<br />port this Watchdog interrupt. The third ioctl's argument is<br />ignored.<br /><br />Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com><br />---<br />runtest/syscalls | 1 +<br />testcases/kernel/syscalls/ioctl/.gitignore | 1 +<br />testcases/kernel/syscalls/ioctl/ioctl_rtc03.c | 88 +++++++++++++++++++<br />3 files changed, 90 insertions(+)<br />create mode 100644 testcases/kernel/syscalls/ioctl/ioctl_rtc03.c<br /> </blockquote><br /><br /><br /> </html>