<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Cyril,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">This patch looks quite good except for some typos.</div><div class="gmail_default" style="font-size:small">(Test get passed on both RHEL8(x86_64) and RHEL7(ppc64))</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 18, 2020 at 12:34 AM Cyril Hrubis <<a href="mailto:chrubis@suse.cz">chrubis@suse.cz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Cyril Hrubis <<a href="mailto:chrubis@suse.cz" target="_blank">chrubis@suse.cz</a>><br></blockquote><div> </div><div><span class="gmail_default" style="font-size:small">Reviewed-by: Li Wang <<a href="mailto:liwang@redhat.com">liwang@redhat.com</a>></span></div><div><span class="gmail_default" style="font-size:small"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 testcases/kernel/syscalls/ipc/shmctl/Makefile |   4 +-<br>
 .../kernel/syscalls/ipc/shmctl/shmctl02.c     | 263 ++++++------------<br>
 2 files changed, 89 insertions(+), 178 deletions(-)<br>
<br>
diff --git a/testcases/kernel/syscalls/ipc/shmctl/Makefile b/testcases/kernel/syscalls/ipc/shmctl/Makefile<br>
index 0172bb495..bc5bd7c2e 100644<br>
--- a/testcases/kernel/syscalls/ipc/shmctl/Makefile<br>
+++ b/testcases/kernel/syscalls/ipc/shmctl/Makefile<br>
@@ -10,7 +10,7 @@ shmctl05: LDLIBS += -lrt<br>
<br>
 include $(top_srcdir)/include/mk/<a href="http://testcases.mk" rel="noreferrer" target="_blank">testcases.mk</a><br>
<br>
-shmctl01 shmctl02 shmctl03 shmctl04 shmctl05: LDLIBS += -lltpipc<br>
-shmctl06: LDLIBS += -lltpnewipc<br>
+shmctl01 shmctl03 shmctl04 shmctl05: LDLIBS += -lltpipc<br>
+shmctl02 shmctl06: LDLIBS += -lltpnewipc<br>
<br>
<span class="gmail_default" style="font-size:small">...</span><br>
+ * * EFAULT - IPC_SET & buf isn't valid<br>
+ * * EFAULT - IPC_STAT & buf isn't valid<br>
+ * * EINVAL - the command is not valid<br>
+ * * EINVAL - the shmid is not valid<br>
+ * * EINVAL - the shmid belongs to removed shm<br>
  *<br>
- * RESTRICTIONS<br>
- *     none<br>
+ * * EPERM - attempt to stat root owned shm<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">^ <span class="gmail_default"></span>EACCES</div><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ * * EPERM - attempt delete root owned shm<br>
+ * * EPERM - attempt to change root owned shm<br>
+ * * EPERM - attempt to lock root owned shm<br>
+ * * EPERM - attempt to unlock root owned shm<br>
  */<br>
<br>
<span class="gmail_default" style="font-size:small">...</span><br>
<br>
-       cleanup();<br>
+       if (TST_ERR == tc[i].error) {<br>
+               tst_res(TPASS | TTERRNO, "msgctl(%i, %i, %p)",<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Here should be shmctl() but not msgctl().</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+                       *tc[i].shm_id, tc[i].cmd, tc[i].buf);<br>
+               return;<br>
+       }<br>
<br>
-       tst_exit();<br>
+       tst_res(TFAIL | TTERRNO, "msgctl(%i, %i, %p) expected %s",<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">msgctl -- > shmctl().</div></div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>