<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 20, 2020 at 6:27 PM Feiyu Zhu <<a href="mailto:zhufy.jy@cn.fujitsu.com" target="_blank">zhufy.jy@cn.fujitsu.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">.<span class="gmail_default" style="font-size:small">..</span><br>
  *     Looping with the -i option does not work correctly.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">This line should be removed since it works well with -i.</div></div><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+static void wait_for_flag(int value)<br>
 {<br>
        while (1) {<br>
                if (*flag == value)<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Sleep 1sec is too long here, we can use usleep(100) for a replacement.</div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+static struct tst_test test = {<br>
+       .setup = setup,<br>
+       .cleanup = cleanup,<br>
+       .test_all = verify_kill,<br>
+       .needs_tmpdir = 1,<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">'.needs_tmdir' is redundant.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+       .needs_root = 1,<br>
+       .forks_child = 1,<br>
+};<br>
</blockquote></div><div class="gmail_default" style="font-size:small"></div><div><div class="gmail_default" style="font-size:small">The remaining part looks good.</div></div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>