<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Petr,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Petr Vorel <<a href="mailto:pvorel@suse.cz">pvorel@suse.cz</a>> wrote:<br></div><div dir="ltr" class="gmail_attr"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-size:small">[...]</span><br>
+static void do_test(unsigned int i)<br>
 {<br>
-       /* check syscall availability */<br>
-       ltp_syscall(__NR_get_mempolicy, NULL, NULL, 0, NULL, 0);<br>
+       struct test_case *tc = &tcase[i];<br>
+       int policy;<br>
+<br>
+       tst_res(TINFO, "test #%d: %s", i+1, tc->desc);<br>
<br>
-       if (!is_numa(NULL, NH_MEMS, 1))<br>
-               tst_brkm(TCONF, NULL, "requires NUMA with at least 1 node");<br>
+       TST_EXP_PASS(get_mempolicy(&policy, getnodemask->maskp, getnodemask->size,<br>
+                          tc->addr, tc->flags), "%s", tc->desc);<br>
<br>
-       TEST_PAUSE;<br>
-       tst_tmpdir();<br>
+               struct bitmask *exp_mask = *(tc->exp_nodemask);<br>
+<br>
+               if (!numa_bitmask_equal(exp_mask, getnodemask)) {<br>
+                       tst_res(TFAIL, "masks are not equal");<br>
+                       tst_res_hexd(TINFO, exp_mask->maskp,<br>
+                               exp_mask->size / 8, "expected:");<br>
+                       tst_res_hexd(TINFO, getnodemask->maskp,<br>
+                               getnodemask->size / 8, "returned:");<br>
+               }<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">These few lines have a code indent issue, otherwise looks good.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Reviewed-by: Li Wang <<a href="mailto:liwang@redhat.com">liwang@redhat.com</a>></div></div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>