<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 15, 2021 at 10:33 PM Alexander Egorenkov <<a href="mailto:egorenar@linux.ibm.com">egorenar@linux.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Increase time waiting for swap memory to settle before<br>
performing checks with occupied swap memory. This decreases the chance<br>
of the test to fail in the case of the swap memory taking longer<br>
than expected to settle.<br>
<br>
This fixes sporadic failures observed on IBM s390x systems such as this:<br>
<br>
swapping01.c:149: TPASS: no heavy swapping detected, 4534 MB swapped.<br>
swapping01.c:106: TINFO: available physical memory: 7348 MB<br>
swapping01.c:109: TINFO: try to allocate: 9552 MB<br>
swapping01.c:112: TINFO: memory allocated: 9552 MB<br>
swapping01.c:140: TINFO: swap free init: 25019 MB<br>
swapping01.c:141: TINFO: swap free now: 20484 MB<br>
swapping01.c:149: TPASS: no heavy swapping detected, 4534 MB swapped.<br>
swapping01.c:106: TINFO: available physical memory: 7348 MB<br>
swapping01.c:109: TINFO: try to allocate: 9553 MB<br>
swapping01.c:112: TINFO: memory allocated: 9553 MB<br>
swapping01.c:140: TINFO: swap free init: 25018 MB<br>
swapping01.c:141: TINFO: swap free now: 17694 MB<br>
swapping01.c:149: TPASS: no heavy swapping detected, 7323 MB swapped.<br>
swapping01.c:106: TINFO: available physical memory: 7318 MB<br>
swapping01.c:109: TINFO: try to allocate: 9514 MB<br>
swapping01.c:112: TINFO: memory allocated: 9514 MB<br>
swapping01.c:140: TINFO: swap free init: 25019 MB<br>
swapping01.c:141: TINFO: swap free now: 17697 MB<br>
swapping01.c:145: TFAIL: heavy swapping detected: 7322 MB swapped.<br>
<br>
Signed-off-by: Alexander Egorenkov <<a href="mailto:egorenar@linux.ibm.com" target="_blank">egorenar@linux.ibm.com</a>><br>
---<br>
testcases/kernel/mem/swapping/swapping01.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/testcases/kernel/mem/swapping/swapping01.c b/testcases/kernel/mem/swapping/swapping01.c<br>
index 24b8313f3..befb52e91 100644<br>
--- a/testcases/kernel/mem/swapping/swapping01.c<br>
+++ b/testcases/kernel/mem/swapping/swapping01.c<br>
@@ -127,10 +127,10 @@ static void check_swapping(void)<br>
<br>
/* Still occupying memory, loop for a while */<br>
i = 0;<br>
- while (i < 10) {<br>
+ while (i < 30) {<br>
swap_free_now = SAFE_READ_MEMINFO("SwapFree:");<br>
sleep(1);<br>
- if (labs(swap_free_now - SAFE_READ_MEMINFO("SwapFree:")) < 512)<br>
+ if (labs(swap_free_now - SAFE_READ_MEMINFO("SwapFree:")) < 10)<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">From test error above, if the system's swap-memory taking longer</div><div class="gmail_default" style="font-size:small">than expected to settle, shouldn't we more even get a swapped </div><div class="gmail_default" style="font-size:small">consumption (=swap_free_init - swap_free_now) less than mem_over_max? </div><div class="gmail_default" style="font-size:small">I say this because am imagining the system's SwapFree keeps</div><div class="gmail_default" style="font-size:small">decreasing during the while loop, as you extend the waiting time</div><div class="gmail_default" style="font-size:small">then we might get a larger swapped value at the final, which makes</div><div class="gmail_default" style="font-size:small">the test more easily to FAIL.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">And the purpose is to detect heavy swapping on s390x but not</div><div class="gmail_default" style="font-size:small">guarantee running with a purified system, there also possible </div><div class="gmail_default" style="font-size:small">other daemons have a side effect on system swaping, so I slightly</div><div class="gmail_default" style="font-size:small">suppose dropping caches before testing may be helpful.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Another thing I wondering, do we really need to loop 5 times for this</div><div class="gmail_default" style="font-size:small">kind of stress testing? Guess one time is enough for testing.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">mm:swapping01 swapping01 -i 5<br></div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
break;<br>
<br>
i++;<br>
-- <br>
2.26.2<br>
<br>
<br>
-- <br>
Mailing list info: <a href="https://lists.linux.it/listinfo/ltp" rel="noreferrer" target="_blank">https://lists.linux.it/listinfo/ltp</a><br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>