<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Viresh Kumar <<a href="mailto:viresh.kumar@linaro.org" target="_blank">viresh.kumar@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-size:small">...</span><br>
> > >   clock_gettime04.c:158: TPASS: CLOCK_BOOTTIME: Difference between successive readings is reasonable for following variants:<br>
> > >   clock_gettime04.c:162: TINFO:   - vDSO or syscall with libc spec<br>
> > >   clock_gettime04.c:162: TINFO:   - syscall with old kernel spec<br>
> > >   clock_gettime04.c:162: TINFO:   - vDSO with old kernel spec<br>
> <br>
> Sorry for putting my opinion late. Instead of repeating variants (duplicity)<br>
> I'd prefer just print variants once at the beginning + print which variant<br>
> failed.<br>
<br>
I too thought about that, but then realized that the variant list<br>
isn't same for all the clocks, like gettimeofday only there for<br>
CLOCK_REALTIME and so let it go.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">But we can put the printing behind the 'gettimeofday+CLOCK_REALTIME' checking.</div><div class="gmail_default" style="font-size:small">Just similar to what I did in patch V1, is that your mean, Petr?</div></div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">--- a/testcases/kernel/syscalls/clock_gettime/clock_gettime04.c<br>+++ b/testcases/kernel/syscalls/clock_gettime/clock_gettime04.c<br>@@ -108,6 +108,9 @@ static void run(unsigned int i)<br>                        if (tv->clock_gettime == my_gettimeofday && clks[i] != CLOCK_REALTIME)<br>                                continue;<br> <br>+                       if (count == 10000)<br>+                                tst_res(TINFO, "\t- %s", tv->desc);<br>+<br>                        ret = tv->clock_gettime(clks[i], tst_ts_get(&ts));<br>                        if (ret) {<br>                                /*<br>@@ -139,8 +142,8 @@ static void run(unsigned int i)<br> <br>                        diff = end + slack - start;<br>                        if (diff < 0) {<br>-                               tst_res(TFAIL, "%s: Time travelled backwards (%d): %lld ns",<br>-                                       tst_clock_name(clks[i]), j, diff);<br>+                               tst_res(TFAIL, "%s(%s): Time travelled backwards (%d): %lld ns",<br>+                                       tst_clock_name(clks[i]), tv->desc, j, diff);<br>                                return;<br>                        }<br></div></div><div><br></div><div><br></div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>