<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Petr,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Petr Vorel <<a href="mailto:pvorel@suse.cz" target="_blank">pvorel@suse.cz</a>> wrote:<br></div><div dir="ltr" class="gmail_attr"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail_default" style="font-size:small">...</span><br>
<br>
> I think it would be worth keeping it simple then and just print all<br>
> variants only once from setup(). Leave the special case of REALTIME<br>
> clock.<br>
+1.<br>
<br>
>From a long term, I'd like some easy solution when printing would be handled in<br>
the library. Some time ago I posted a patch which turned .test_variants from int<br>
into array of string description [1]. Cyril didn't see much value at it and<br></blockquote><div><br></div>I look back at patch[1], <span class="gmail_default" style="font-size:small"></span>IMHO, <span class="gmail_default" style="font-size:small"></span>splitting the test variant<span class="gmail_default" style="font-size:small"> struct </span>is not a good idea.</div><div class="gmail_quote"><span class="gmail_default" style="font-size:small">I'd rather go print variants[i].desc in the library directly but not split it to make</span></div><div class="gmail_quote"><span class="gmail_default" style="font-size:small">struct here and there :).</span></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
didn't like that it introduced more ifdefs (together with Viresh).<br>
But now we have docparse, could we reconsider this approach? Maybe we could keep<br>
.test_variants and introduce .test_variants_desc for tests which are simple enough.<br>
Or, maybe there is a cleaner solution for clock_adjtime0* tests which I don't<br>
see.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Maybe there is.  We can have more time to thinking/discussing this.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">So, would you mind if I merge this V2 patch first? </div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">(Since we're encountering a sporadical(we can't reproduce it manually)</div><div class="gmail_default" style="font-size:small">failure. Hope this can print more useful info to locate the issue.)</div><div class="gmail_default" style="font-size:small"> <br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Kind regards,<br>
Petr<br>
<br>
[1] <a href="https://patchwork.ozlabs.org/project/ltp/patch/20200519120725.25750-1-pvorel@suse.cz/" rel="noreferrer" target="_blank">https://patchwork.ozlabs.org/project/ltp/patch/20200519120725.25750-1-pvorel@suse.cz/</a><br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>