<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Li Wang <<a href="mailto:liwang@redhat.com">liwang@redhat.com</a>> wrote:<br></div></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+Commit messages should have<br>
+<br>
+* Author's `Signed-off-by` tag<br>
+* Committer's `Reviewed-by` or `Signed-off-by` tag<br></blockquote><div><br></div><div><div style="font-size:small">Or adding `Acked-by:` also acceptable?</div><div style="font-size:small"><br></div><div style="font-size:small">I'm not sure what's the difference between Acked-by and Reviewed-by,</div><div style="font-size:small">but personally feel the Acked-by has more confidence in the reviewing.</div><div style="font-size:small"><br></div><div style="font-size:small">In my mind,</div><div style="font-size:small"><br></div><div style="font-size:small">`Acked-by` means:</div><div style="font-size:small">code review OK, compiled OK, executed OK, has confidence it OK for all arches</div><div style="font-size:small"><br></div><div style="font-size:small">`Reviewed-by` means:</div><div style="font-size:small">code review OK, compiled and executed OK just locally or optional, still<span style="color:rgb(51,51,51);font-size:14px"> room for improvement/discussion</span></div></div></div></div></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Plz ignore my rough understanding, I find a precise description at kernel process/submitting-patches.rst.</div><div class="gmail_quote"><br></div><div class="gmail_default" style="font-size:small"><a href="https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst#when-to-use-acked-by-cc-and-co-developed-by" target="_blank">https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst#when-to-use-acked-by-cc-and-co-developed-by</a></div></div><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>