<div dir="ltr"><br>> Nice work on API converting and cleanup, pushed!<br><br>BTW, I made some modifications in a separate patch<span class="gmail_default" style="font-size:small">[1]</span>, because<div>I forget to submit them in the last code-reviewing.</div><div><br><a href="https://github.com/linux-test-project/ltp/commit/b71b1a494be4126917221bb3b78594ec25c71ea0">https://github.com/linux-test-project/ltp/commit/b71b1a494be4126917221bb3b78594ec25c71ea0</a><br><br>--- a/testcases/kernel/syscalls/reboot/reboot02.c<br>+++ b/testcases/kernel/syscalls/reboot/reboot02.c<br>@@ -31,7 +31,7 @@<br> char nobody_uid[] = "nobody";<br> struct passwd *ltpuser;<br> <br>-static struct test_case_t {<br>+static struct tcase {<br>        int flag;<br>        int exp_errno;<br>        const char *option_message;<br>@@ -40,19 +40,19 @@ static struct test_case_t {<br>        {LINUX_REBOOT_CMD_CAD_ON, EPERM, "LINUX_REBOOT_CMD_CAD_ON"},<br> };<br> <br>-static void run(int n)<br>+static void run(unsigned int n)<br> {<br>-       struct test_case_t *tcase = &tcases[n];<br>+       struct tcase *tc = &tcases[n];<br> <br>        if (n == 0)<br>-               TST_EXP_FAIL(reboot(tcase->flag),<br>-                       tcase->exp_errno, "%s", tcase->option_message);<br>+               TST_EXP_FAIL(reboot(tc->flag),<br>+                       tc->exp_errno, "%s", tc->option_message);<br>        else {<br>                ltpuser = SAFE_GETPWNAM(nobody_uid);<br>                SAFE_SETEUID(ltpuser->pw_uid);<br> <br>-               TST_EXP_FAIL(reboot(tcase->flag),<br>-                       tcase->exp_errno, "%s", tcase->option_message);<br>+               TST_EXP_FAIL(reboot(tc->flag),<br>+                       tc->exp_errno, "%s", tc->option_message);<br> <br>                SAFE_SETEUID(0);<br>        }<br><br><br>-- <br>Regards,<br>Li Wang</div></div>