<html xmlns='http://www.w3.org/1999/xhtml'> <head><meta http-equiv='content-type' content='text/html;charset=utf-8'></head><body><div><div id="MailBelowDiv"></div><div style="word-wrap: break-word;"><div>This change makes sense.</div><div><br></div><div>On my computer, the last CPU can't be offline, which causes the execution of this testcase to fail.</div><div><br></div><div>However, the testcase makes special treatment to the last CPU. If the last CPU cannot be offline, the execution result of the testcase should not be affected.</div><div><br></div><div>Therefore, if cpu0 does not have an online file, it will lead to an error in the judgment of the last CPU.<br><div id="sign"><hr width="300" align="left"><p style="font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px; background: rgb(254, 254, 254);"><strong><span style="font-size: 13.5pt;">统信软件技术有限公司</span></strong><span lang="EN-US"> </span></p><p style="font-family: tah
oma, arial, helvetica, sans-serif; font-size: 12px; background: rgb(254, 254, 254);"><strong><span lang="EN-US" style="font-size: 7.5pt;">UnionTech Software Technology Co., Ltd. </span></strong><span style="font-size: 10pt;"> </span></p><p style="font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px; background: rgb(254, 254, 254);"><span style="background-color: rgb(255, 255, 255); font-size: 10pt;">官网：</span><span lang="EN-US" style="background-color: rgb(255, 255, 255); font-size: 10pt; font-family: Tahoma, sans-serif;">www.uniontech.com</span><span style="font-size: 9pt; background-color: rgb(255, 255, 255);"> </span></p><p style="background-color: rgb(255, 255, 255); font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px;"><br></p><div style="color: rgb(51, 51, 51); background-color: rgb(255, 255, 255);"><span style="font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px;">此电子邮件消息仅供预期收件人
用，其中可能包含保密或特权使用信息。如果您不是预期收件人，请勿使用、传播、分发或复制此电子邮件或信赖此邮件采取任何行动。如果您误收了此邮件，请立即回复邮件通知统信软件技术有限公司发件人，并删除误收电子邮件及其相关附件。感谢配合！</span> </div><div style="color: rgb(51, 51, 51); background-color: rgb(255, 255, 255);"><span style="font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px;"><br></span> </div><div style="color: rgb(51, 51, 51); background-color: rgb(255, 255, 255);"><span style="font-family: tahoma, arial, helvetica, sans-serif; font-size: 12px;">This email message is intended only for the use of the individual or entity who/which is the intended recipient and may contain information that is privileged or confidential. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or
copying of, or taking any action in reliance on, this e-mail is strictly prohibited. If you have received this email in error, please notify UnionTech Software Technology immediately by replying to this e-mail and immediately delete and discard all copies of the e-mail and the attachment thereto (if any). Thank you.</span> </div></div></div>------------------------------------------------------------------<div><br></div></div><div id="summernote"><div id="MailBelowDiv"></div></div><div dir="ltr"><div dir="ltr"><div style="font-size:small" class="gmail_default"><br></div></div><br><div class="gmail_quote"><div class="gmail_attr" dir="ltr">On Mon, Jun 28, 2021 at 11:03 AM <<a href="mailto:gouhao@uniontech.com">gouhao@uniontech.com</a>> wrote:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"> <div><div><div id="gmail-m_-2047747051835399752MailBelowDiv"></div><div style="over
flow-wrap: break-word;"><div>hi, LiWang,</div><div><br></div><div>My cpu is Hygon C86 7185 32-core Processor, x86_64 architecture， kernel is 4.19.90</div><div>Only cpu0 has no files，It doesn't seem to have anything to do with the kernel. I tried other kernels, too</div></div></div></div></blockquote><div><br></div><div><div style="font-size:small" class="gmail_default">Thanks for the info.</div><div style="font-size:small" class="gmail_default"><br></div><div style="font-size:small" class="gmail_default">I checked my laptop (5.12.11-300.fc34.x86_64), it has no 'online' file in the first cpu0 as well.</div>It <span style="font-size:small" class="gmail_default">seems common to consider</span> cpu0 is always online, so it won’t have “cpu0/online”.</div><div><div style="font-size:small" class="gmail_default">(I got this view from google search ^)</div><br></div><div><div style="font-size:small" class="gmail_default"><br></div><div style="font-size:small" clas
s="gmail_default">But go back to your patch, does it really make sense to correct</div><div style="font-size:small" class="gmail_default">the judgment of the last CPU?</div><div style="font-size:small" class="gmail_default"><br></div><div style="font-size:small" class="gmail_default">If I understand correctly, the original judgment is purposely to</div><div style="font-size:small" class="gmail_default">guarantee all CPUs can be safely offline, so if there is already</div><div style="font-size:small" class="gmail_default">a cpu0 without an 'online' file, it will be filtered out, right? This</div><div style="font-size:small" class="gmail_default">means all of the remaining hotplugged CPUs can be offline safely. </div><div style="font-size:small" class="gmail_default">In this case, the judgment of the last CPU is losing effect as</div><div style="font-size:small" class="gmail_default">expected. Why should we correct it?</div><div style="font-size:s
mall" class="gmail_default"><br></div><div style="font-size:small" class="gmail_default">Or, do you get any failures/abnormal in testing?</div><br></div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div><div><div style="overflow-wrap: break-word;"><div><br></div><div>Attached is a screenshot.<br><div id="gmail-m_-2047747051835399752sign"><hr align="left" width="300"><p style="font-family:tahoma,arial,helvetica,sans-serif;font-size:12px;background:rgb(254,254,254)"><strong><span style="font-size:13.5pt">统信软件技术有限公司</span></strong><span lang="EN-US"> </span></p><p style="font-family:tahoma,arial,helvetica,sans-serif;font-size:12px;background:rgb(254,254,254)"><strong><span style="font-size:7.5pt" lang="EN-US">UnionTech Software Technology Co., Ltd. </span></strong><span style="font-size:10pt"> </span></p><p style="font-family:tahoma,aria
l,helvetica,sans-serif;font-size:12px;background:rgb(254,254,254)"><span style="background-color:rgb(255,255,255);font-size:10pt">官网：</span><span style="background-color:rgb(255,255,255);font-size:10pt;font-family:Tahoma,sans-serif" lang="EN-US"><a href="http://www.uniontech.com">www.uniontech.com</a></span><span style="font-size:9pt;background-color:rgb(255,255,255)"> </span></p><p style="background-color:rgb(255,255,255);font-family:tahoma,arial,helvetica,sans-serif;font-size:12px"><br></p><div style="color:rgb(51,51,51);background-color:rgb(255,255,255)"><span style="font-family:tahoma,arial,helvetica,sans-serif;font-size:12px">此电子邮件消息仅供预期收件人使用，其中可能包含保密或特权使用信息。如果您不是预期收件人，请勿使用、传播、分发或复制此电子邮件或信赖此邮件采取任何行动。如果您误收了此邮件，请立即回复邮件通知统信软件技术有限公司发件人，并删除误收
电子邮件及其相关附件。感谢配合！</span> </div><div style="color:rgb(51,51,51);background-color:rgb(255,255,255)"><span style="font-family:tahoma,arial,helvetica,sans-serif;font-size:12px"><br></span> </div><div style="color:rgb(51,51,51);backgrou
nd-color:rgb(255,255,255)"><span style="font-family:tahoma,arial,helvetica,sans-serif;font-size:12px">This email message is intended only for the use of the individual or entity who/which is the intended recipient and may contain information that is privileged or confidential. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of, or taking any action in reliance on, this e-mail is strictly prohibited. If you have received this email in error, please notify UnionTech Software Technology immediately by replying to this e-mail and immediately delete and discard all copies of the e-mail and the attachment thereto (if any). Thank you.</span> </div></div></div>------------------------------------------------------------------<div><br></div></div><div id="gmail-m_-2047747051835399752summernote"><div id="gmail-m_-2047747051835399752MailBelowDiv"></div></div><div dir="ltr"><div dir="ltr"><div style="fon
t-size:small">Hi Hao,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 28, 2021 at 9:16 AM Gou Hao <<a href="mailto:gouhao@uniontech.com">gouhao@uniontech.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: gouhao <<a href="mailto:gouhao@uniontech.com">gouhao@uniontech.com</a>><br>
<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Cpuhotplug04 uses get_hotplug_cpus when traversing, <br>
get_hotplug_cpus will filter out cpu without online files, <br>
and $cpus_num will be used to determine the last cpu num。</blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
If some cpu do not have an online file, <br>
it will lead to an error in the judgment of the last cpu.<br></blockquote><div><br></div><div><div style="font-size:small">I'm wondering what kind of CPU does not have the online file, and which</div><div style="font-size:small">kernel version is being used? Is that test machine an x86 or MIPS?</div></div></div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>
</div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div class="gmail_signature" dir="ltr"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>
</div></body></html>