<style>table.customTableClassName {margin-bottom: 10px;border-collapse: collapse;display: table;}.customTableClassName td, .customTableClassName th {border: 1px solid #ddd;}</style><p style="margin:0px;"><br></p><p style="margin:0px;"><br></p><p style="margin:0px;">Hi LiWang:<br></p><p style="margin:0px;"><br></p><p style="margin:0px;">you are right. </p><p style="margin:0px;"><br></p><p style="margin:0px;">I asked the CPU manufacturers and tried several kernel, which should be the problem of the kernel. </p><p style="margin:0px;"><br></p><p style="margin:0px;">I don't understand the code right.<br></p><p style="margin:0px;"><br></p><p style="margin:0px;">Thank you very much.</p><div id="write-custom-companySignature"> </div><p style="margin:0px;"><br>
</p><div style="padding:5px;padding-left:0px;border-top:solid #999 1.0pt;font-family: arial; font-size:12px;margin-bottom:20px;"><p style="margin:0px;"><strong>From:</strong> "Li Wang <liwang@redhat.com>"</p><p style="margin:0px;"><strong>To:</strong> "gouhao <gouhao@uniontech.com>"</p><p style="margin:0px;"><strong>CC:</strong> "LTP List <ltp@lists.linux.it>","jiaofenfang <jiaofenfang@uniontech.com>","weidong <weidong@uniontech.com>"</p><p style="margin:0px;"><strong>Sent:</strong> 2021-06-28 12:27</p><p style="margin:0px;"><strong>Subject:</strong> Re: Re: Re: [LTP] [PATCH] fix cpuhotplug04 check last cpu error【Suspected phishing email, please pay attention to password security】</p></div><div dir="ltr"><br><br>
<div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 28, 2021 at 11:58 AM <<a href="mailto:gouhao@uniontech.com">gouhao@uniontech.com</a>> wrote: <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div style="overflow-wrap: break-word;"><div>This change makes sense.</div><br><div>On my computer, the last CPU can't be offline, which causes the execution of this testcase to fail.</div></div></div></div></blockquote><br><div class="gmail_default" style="font-size:small">But the CPU0 on your system will always online, so the last one should be offline safely.</div><div class="gmail_default" style="font-size:small">If it not, that might a kernel issue I guess.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div style="overflow-wrap: break-word;"><br><div>However, the testcase makes special treatment to the last CPU. If the last CPU cannot be offline, the execution result of the testcase should not be affected.</div></div></div></div></blockquote><br><div class="gmail_default" style="font-size:small">Yes, but from cpuhotplug04.sh comment line#84:</div><br><div class="gmail_default" style="font-size:small"># If all the CPUs are hotpluggable, we expect <br> # that the kernel will refuse to offline the last CPU. <br> # If only some of the CPUs are hotpluggable, <br> # they all can be offlined. <br></div><br><div class="gmail_default" style="font-size:small">How do you think of this description? In your system, it obviously belongs to</div><div class="gmail_default" style="font-size:small">the second scenario that the cpu0 is online and you should be able to offline</div><div class="gmail_default" style="font-size:small">all the remaining hotplugged one, isn't it?</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div style="overflow-wrap: break-word;"><br><div>Therefore, if cpu0 does not have an online file, it will lead to an error in the judgment of the last CPU.</div></div></div></div></blockquote><br><div class="gmail_default" style="font-size:small">If cpu0 does not have an online file, that means the last CPU (hotplugged) can be offline as well.</div><div class="gmail_default" style="font-size:small">To verify this assumption, you can try manually offline CPU one by one, this time I suggest you</div><div class="gmail_default" style="font-size:small">try the last one first.</div></div><div><br>
</div>--
<br>
<div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards, <br> </div><div>Li Wang <br> </div></div></div></div>