<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Cyril Hrubis <<a href="mailto:chrubis@suse.cz">chrubis@suse.cz</a>> wrote:<br></div></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I guess that appending '-o size ...' to the mount flags in prepare_device()<br>
is reasonable, but instead of hardcoing the value we should do the same<br>
as we do with the loop devices and the size should be<br>
MAX(tst_test->dev_min_size, DEV_SIZE_MB).<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Yes, dynamically setting the size is better.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> /dev/loop0 tmpfs 126G 23G 104G 18%<br>
<br>
Also it looks like should pass something as "ltp-tmpfs" instead of the<br>
"/dev/loopX" string in a case of "tmpfs" filesystem in order not to<br>
confuse people...<br></blockquote><div><br></div><div class="gmail_default" style="font-size:small">Quite good proposals, I have sent two patches for achieving the ideas.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks!</div><div class="gmail_default" style="font-size:small"></div></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Li Wang<br></div></div></div></div>